Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inter Planetarify #240

Merged
merged 56 commits into from
Sep 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
351ef51
added Play-all button to list view
femans Sep 9, 2022
30b74b7
added playlist store and fill store when click Play all button
femans Sep 9, 2022
0c34143
cast playlist to localStorage and recover from localStorage. move to …
femans Sep 12, 2022
a09615b
add playlist view; remove obsolete code from searchFilterMenu
femans Sep 12, 2022
46cf53f
add music icon to app bar. Add enqueue function
femans Sep 12, 2022
698f68e
added playlist panel
femans Sep 13, 2022
d396d6f
double click playlist entry to play it in the audioplayer
femans Sep 13, 2022
60fdda5
refactored audiocontrols and audioplayer in to typescript
femans Sep 14, 2022
2722f2c
lots of styling fixes, scrollbar fixes, bug fixes, other fixes
femans Sep 15, 2022
5fe7a48
got reactivity to work for the audio list
femans Sep 15, 2022
6331010
stuff works again
femans Sep 16, 2022
2d482fa
playlist playing working
femans Sep 16, 2022
4148a3f
add skip controls to player. Add blinking play button for song that i…
femans Sep 16, 2022
7f50204
fix: cancel audio playback when play video
femans Sep 16, 2022
39c6cf1
auto skip error files. remove white dots. Disable next/prev buttons f…
femans Sep 17, 2022
35a0999
fixed audio item search view box sizing
femans Sep 17, 2022
dabecc1
introducing unrelated feature: FileType Icons
femans Sep 17, 2022
9f780a1
fix spacing of buttons on general page
femans Sep 17, 2022
21d5ffa
cleanup search list view
femans Sep 17, 2022
9860c23
responsive alignment of searchview
femans Sep 17, 2022
de49804
responsive alignment of searchview video fix
femans Sep 17, 2022
57367a8
responsive alignment of searchview video fix; fix audio play/enqueue …
femans Sep 17, 2022
f411548
make search field small in playlist mode
femans Sep 17, 2022
80c18a0
loop function
femans Sep 17, 2022
5b78030
fast link to audio detail
femans Sep 18, 2022
22bcbda
major improvement to Home view: remove text panels; several responsiv…
femans Sep 19, 2022
79f301a
adjust scrollbar of search page for footer
femans Sep 19, 2022
c1d4584
scrollbars finally working properly!
femans Sep 19, 2022
cab1546
some more responsiveness fixes; introducing the color "planetifyDark"
femans Sep 19, 2022
7cbbcb8
add delete entry function. add more styling to playlist entries
femans Sep 19, 2022
f3abf15
added slogan "Searching the Universe since 2017", fixes #221
femans Sep 20, 2022
a7b1b6c
z-index of settings menu fixed
femans Sep 20, 2022
c159cb0
less obtruse buttons for search list headers
femans Sep 20, 2022
64c51f3
some better icons for buttons
femans Sep 20, 2022
5621a02
fix codeclimate issues
femans Sep 20, 2022
76fc1b7
improvements to big screen responsiveness
femans Sep 20, 2022
37d68e3
empty playlist note
femans Sep 20, 2022
f5869a0
empty playlist note - fix for small screen
femans Sep 20, 2022
93dd2a4
remove z-index from audio player
femans Sep 20, 2022
de93e68
fix scrolling issues
femans Sep 21, 2022
a2a7c1e
fix for vuetify bug with v-scroll directive; upgrade of vuetify
femans Sep 22, 2022
0f61333
fix bug #241
femans Sep 22, 2022
c0bfb81
fix the scrolling bug again
femans Sep 22, 2022
f77ac60
small fix in videolist component
femans Sep 22, 2022
7e99211
remove disabled button styles for banner
femans Sep 23, 2022
37d57e1
alignment of searchbar
femans Sep 23, 2022
256a78d
change file details icon
femans Sep 23, 2022
2728713
remove accidental styling causing weird behavior
femans Sep 23, 2022
e06bc65
make planetifyDark color even darker
femans Sep 23, 2022
a1ff37b
simplify some code
femans Sep 23, 2022
b112ca7
remove some if statements
femans Sep 23, 2022
1175341
undo removeal of if statements
femans Sep 23, 2022
bcc72f3
attempt to reduce cognitive complexity
femans Sep 23, 2022
e6ffd69
another attempt to reduce cognitive complexity
femans Sep 23, 2022
671a100
Revert "attempt to reduce cognitive complexity"
femans Sep 23, 2022
1a5d7a8
revert
femans Sep 23, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions allowJavaScriptModules.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
// declare any JS files that are imported into TS files without implicit specific type declarations
// for some guidance: https://blog.atomist.com/declaration-file-fix/

declare module "@/store";
4 changes: 2 additions & 2 deletions index.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!DOCTYPE html>
<html lang="en">
<html lang="en" style="overflow-y: hidden">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
Expand All @@ -25,7 +25,7 @@
enabled. Please enable it to continue.</strong
>
</noscript>
<div id="app"></div>
<div id="app"/>
<script type="module" src="/src/main.js"></script>
</body>
</html>
44 changes: 35 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,13 @@
"vue-masonry": "^0.11.8",
"vue-router": "^4.0.15",
"vue-timeago3": "^2.2.1",
"vuetify": "3.0.0-beta.5",
"vuetify": "3.0.0-beta.11",
"vuex": "^4.0.2"
},
"devDependencies": {
"@mdi/js": "^6.9.96",
"@types/howler": "^2.2.7",
"@types/mime": "^3.0.1",
"@typescript-eslint/eslint-plugin": "^5.31.0",
"@typescript-eslint/parser": "^5.31.0",
"@vitejs/plugin-vue": "^2.3.3",
Expand Down
39 changes: 13 additions & 26 deletions src/App.vue
Original file line number Diff line number Diff line change
@@ -1,24 +1,28 @@
<script setup>
//TODO: make AppHeader generic also for homeview
import AppHeader from "@/components/pageLayout/AppHeader.vue";
import { useDisplay } from "vuetify";
import { useRoute } from "vue-router";
import PlayList from "./components/pageLayout/PlayList.vue";
import AudioDetail from "@/components/detailViewComponents/AudioDetail.vue";

const { mdAndUp } = useDisplay();
const route = useRoute();

import { playerActive } from "@/composables/audioControls";
import { audioDetailPopup } from "@/composables/audioControls";
import { useFooter } from "@/composables/footer.ts";
const { adjustFooterPadding } = useFooter();
</script>

<template>
<v-app dark hidden class="overflow-hidden">
<app-header v-if="route.name !== 'Home'" />
<v-app id="v-app" dark hidden style="height: 100vh">
<app-header />

<v-main id="main">
<v-main class="h-100" :style="{ 'padding-bottom': adjustFooterPadding }">
<play-list />
<audio-detail v-if="audioDetailPopup" :file="audioDetailPopup" />
<router-view />
</v-main>

<AudioPlayer v-if="playerActive" />
<AppFooter v-else-if="route.name === 'Home' || (route.name === 'Search' && mdAndUp)" />
<AudioPlayer />
<AppFooter />
</v-app>
</template>

Expand All @@ -42,15 +46,6 @@ export default {
</script>

<style lang="scss" scoped>
h2 {
font-size: 120%;
letter-spacing: 0.09em;
font-weight: 500;
span {
font-weight: 500;
}
}

/*
This is due to a bug with the application height in Safari on IPhone
https://stackoverflow.com/questions/62167456/use-of-v-app-bar-causes-v-content-to-always-have-an-overflow-identical-to-the-he
Expand All @@ -61,12 +56,4 @@ h2 {
min-height: calc(100vh - 56px) !important;
}
}

#main {
position: absolute;
top: 0;
left: 0;
bottom: 0;
right: 0;
}
</style>
10 changes: 0 additions & 10 deletions src/components/DetailView.vue
Original file line number Diff line number Diff line change
Expand Up @@ -159,13 +159,3 @@ export default {
},
};
</script>

<style lang="scss">
.detail {
position: absolute;
top: 0;
left: 0;
bottom: 0;
right: 0;
}
</style>
Loading