-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add DHT and RequestResponse notifications #461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgins
changed the title
Bgins/add dht req resp notifications
Add DHT and RequestResponse notifications
Dec 4, 2023
bgins
changed the title
Add DHT and RequestResponse notifications
feat: Add DHT and RequestResponse notifications
Dec 4, 2023
bgins
force-pushed
the
bgins/add-dht-req-resp-notifications
branch
2 times, most recently
from
December 11, 2023 18:17
16e3184
to
56035fe
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
==========================================
- Coverage 70.26% 68.14% -2.13%
==========================================
Files 80 81 +1
Lines 9128 9476 +348
==========================================
+ Hits 6414 6457 +43
- Misses 2714 3019 +305
|
bgins
force-pushed
the
bgins/add-dht-req-resp-notifications
branch
2 times, most recently
from
December 13, 2023 05:42
569b44a
to
dd4661f
Compare
We have the peer ID already in the RequestResponse Message.
We have internal mechanisms for determining when to add nodes to the DHT. Without the kad::BucketInserts::Manual setting, nodes are always added to the DHT OnConnect.
bgins
force-pushed
the
bgins/add-dht-req-resp-notifications
branch
from
January 8, 2024 22:59
8aff5e3
to
775c3ef
Compare
zeeshanlakhani
requested changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. I finally got through it. A mix-match of comments/minor-fixes. Also, want to chat on one thing @bgins.
We want to avoid blocking swarm events.
zeeshanlakhani
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dx
Developer experience applications and improvements
networking
Features, functionality involving networking
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the following changes:
Ipld
data, not just stringsFoundEvent
intoDecodedRecord
andFoundEvent
(to include extra information onFoundEvent
without overloading decoding mechanism)IndexedResources
decoding and add/update unit tests to check ittest_libp2p_receipt_gossip_serial
integration testcheck_lines_for
test utility tocheck_for_line_with
handler_timeout_fn
sdefaults.toml
fromhomestar-runtime/fixtures
tohomestar-runtime/config
ReceivedReceiptPubsub
notification "peerId" field to "publisher" to better reflect the role of the peer (breaking change for clients).retrieve_from_query
intoretrieve_from_dht
andretrieve_from_provider
retrieve_from_dht
error or timeoutkad::BucketInserts::Manual
configurationRequestResponse
ResponseSent
event with a debug log (instead of leaving it uncaught)Link to issue
Closes #131
Closes #475
Type of change
The breaking change is the update to the
ReceivedReceiptPubsub
notification.Test plan (required)
We've added tests to check:
We also have the starts for a test of got receipt from DHT that will be used with future updates to receipt retrieval (in the
test_libp2p_dht_records_serial
test, but commented out)