[chore][deps] Bump otel-collector to 0.113.0 and fix failing unit test

[mahadzaryab1]

Which problem is this PR solving?

• Continuation of chore(deps): bump the otel-collector group across 1 directory with 48 updates #6175.
• There was a breaking change made in updated grpc config to use DialContext open-telemetry/opentelemetry-collector#11575 that updates ToClientConn to use DialContext instead of NewClient because of a bug. DialContext uses the passthrough scheme was resulting in the following error when the endpoint is left empty. This PR fixes the unit tests by setting the endpoint in the test configs to be non-empty.

grpc storage builder failed to create a store: error creating traced remote storage client: failed to exit idle mode: passthrough: received empty target in Build()

How was this change tested?

• CI

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[mahadzaryab1]

@yurishkuro Getting a goleak error and can't seem to figure out why.

goleak: Errors on successful test run: found unexpected goroutines:
[Goroutine 28 in state select, with net.(*sysDialer).dialParallel on top of the stack:
net.(*sysDialer).dialParallel(0x140003ba000, {0x10197f7b8, 0x14000392270}, {0x1400038c4c0, 0x1, 0x1}, {0x1400038c4d0, 0x1, 0x1})
	/Users/mzaryab/go/pkg/mod/golang.org/[email protected]/src/net/dial.go:577 +0x318
net.(*Dialer).DialContext(0x140000bf138, {0x10197f7b8, 0x14000392270}, {0x101642a4d, 0x3}, {0x140000d220f, 0xa})

It seems to be coming from this test. Any ideas?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (81397e5) to head (25d7a9a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6197   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         354      354           
  Lines       20127    20127           
=======================================
  Hits        19418    19418           
  Misses        524      524           
  Partials      185      185           

Flag	Coverage Δ
badger_v1	8.31% <ø> (ø)
badger_v2	1.67% <ø> (ø)
cassandra-4.x-v1	14.39% <ø> (ø)
cassandra-4.x-v2	1.61% <ø> (ø)
cassandra-5.x-v1	14.39% <ø> (ø)
cassandra-5.x-v2	1.61% <ø> (ø)
elasticsearch-6.x-v1	18.60% <ø> (ø)
elasticsearch-7.x-v1	18.68% <ø> (ø)
elasticsearch-8.x-v1	18.84% <ø> (-0.01%)	⬇️
elasticsearch-8.x-v2	1.66% <ø> (ø)
grpc_v1	9.48% <ø> (ø)
grpc_v2	7.00% <ø> (+<0.01%)	⬆️
kafka-v1	8.88% <ø> (ø)
kafka-v2	1.67% <ø> (ø)
memory_v2	1.67% <ø> (ø)
opensearch-1.x-v1	18.73% <ø> (+<0.01%)	⬆️
opensearch-2.x-v1	18.73% <ø> (ø)
opensearch-2.x-v2	1.66% <ø> (-0.02%)	⬇️
tailsampling-processor	0.46% <ø> (ø)
unittests	95.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mahadzaryab1]

It looks to be passing in the CI but its failing locally for me

[yurishkuro]

this doesn't look like a quality fix to me. Giving it a fake address may cause undesired connection, which could explain go leaks.

[mahadzaryab1]

@yurishkuro I believe it doesn't matter what this is for the unit tests it just shouldn't be blank to avoid the empty build error - changed it to just a random string now

[mahadzaryab1]

@yurishkuro sorry! you were right - i changed the ports to be :0 and it looks good now

[yurishkuro]

should we just delete comment-out this test? (with TODO and an issue to restore later once grpc fix is done).

[mahadzaryab1]

@yurishkuro I think its okay to leave it because DialContext calls NewClient (ref: https://github.com/grpc/grpc-go/blob/master/clientconn.go#L225). What do you think?

[yurishkuro]

I don't really get it - the change in OTEL is to use DialContext - is it a pro-active function that actually performs the connection? If so giving it :0 port doesn't make sense - where would it connect?

[mahadzaryab1]

@yurishkuro It seems like DialContext is a wrapper around NewClient and it exits IdleMode which presumably performs the connection (ref: https://github.com/grpc/grpc-go/blob/master/clientconn.go#L225). Using :0 will just use any available port.

[yurishkuro]

please rebase