Include Channel Number with Live TV Channels #2017
Open
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelcresswell
changed the title
TwitchBronBron
approved these changes
Oct 28, 2024
jimdogx
approved these changes
Nov 5, 2024
cewert
reviewed
Nov 6, 2024
| @@ -5,7 +5,11 @@ import "pkg:/source/utils/config.bs" | |||
| sub setFields() | |||
| json = m.top.json | |||
| m.top.id = json.id | |||
| m.top.title = json.name | |||
| if isValid(json.number) | |||
| m.top.title = `CH ${json.number} ${json.name}` | |||
There was a problem hiding this comment.
Do all languages use CH to abbreviate "Channel"? We should probably be translating this string so other languages can customize it if needed
cewert
added
the
general-improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a channel number to Live TV displays.
Issues
Fixes #2016