Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Channel Number with Live TV Channels #2017

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+10 −1
Open

Include Channel Number with Live TV Channels #2017

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db8485c
Add channel number to Live TV channel title
Oct 27, 2024
572cce8
Make more robust with validation function and string template
Oct 28, 2024
dae7677
Add localization for channel abbreviation string
Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/data/ChannelData.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ import "pkg:/source/utils/config.bs"
sub setFields()
json = m.top.json
m.top.id = json.id
m.top.title = json.name
if isValid(json.number)
m.top.title = `CH ${json.number} ${json.name}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do all languages use CH to abbreviate "Channel"? We should probably be translating this string so other languages can customize it if needed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, let me know if there is anything I need to do for other languages

else
m.top.title = json.name
end if
m.top.live = true
m.top.Type = "TvChannel"
setPoster()
Expand Down
Loading