mca #59
Open
mca #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add encode_if_py2 decorator. Bump version. [Resolves #25]
…sed InvalidNameError.
This commit ensures that the tests pass no matter the user has installed whichever parsing library with bs4.
**Explanation:**
When using lxml (recommended parser in BeautifulSoup4) the parsing is little different then the inbuilt parser:
BeautifulSoup('<input name="hi">')
# gives "<html><body><input name='hi' /></body></html>"
# while the inbuilt parser gives "<input name='hi' />"
# Thus the add_field function used to fail by giving InvalidNameError
The parsing of complicated forms is way much better using `lxml` and RoboBrowser compliments it well.
The only issue caused was due to the individual field parsings.
Forcing inbuilt parser for fields parsing fixes the issues with individual fields while ensuring the efficiency of lxml for parsing of forms.
Do not install tests
* Add `disabled` property on form fields. * Exclude disabled fields from serialized output. * Update unit tests. [Resolves #42]
Method defaults to "get", but can be overridden using the optional `method` parameter. [Resolves #27]
[Resolves #23]
Replace magical property creation in metaclass with explicit `@property` and `@setter` decorators in field classes.
The Genius website (formerly Rap Genius) changed, which broke the existing documentation example. The search results now include results matching song title as well as artist, making it difficult to guarantee the first song would match the artist being searched for. As a result the example was updated to search for a more unique band name. [Resolves #33]
Update docs for change to Rap Genius website
[Resolves #28]
Urllib3 comes with good retry logic, which is exposed through the requests `HTTPAdapter`. Attach retry options to the session adapters and delete custom retry logic from robobrowser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.