Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mca #59

Open
wants to merge 30 commits into
base: multi-submit
Choose a base branch
from
Open

mca #59

wants to merge 30 commits into from

Commits on Jul 27, 2014

  1. Add tests for default values on multi-option fields.

    @jmcarp
    jmcarp committed Jul 27, 2014
    Configuration menu
    Copy the full SHA
    ba70b58 View commit details
    Browse the repository at this point in the history

  2. Bump version.

    @jmcarp
    jmcarp committed Jul 27, 2014
    Configuration menu
    Copy the full SHA
    e53ae57 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2014

  1. Clean up API; document changes; bump version.

    @jmcarp
    jmcarp committed Jul 28, 2014
    Configuration menu
    Copy the full SHA
    3c37c92 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2014

  1. Handle unicode in Form::__repr__. 

    Add encode_if_py2 decorator.
Bump version.
[Resolves #25]
    @jmcarp
    jmcarp committed Sep 15, 2014
    Configuration menu
    Copy the full SHA
    1ebc91c View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2014

  1. Do not install tests

    @voyageur
    voyageur committed Dec 4, 2014
    Configuration menu
    Copy the full SHA
    eed1e00 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2015

  1. Switched requirements from == to >=.

    @StuntsPT
    StuntsPT committed Jan 13, 2015
    Configuration menu
    Copy the full SHA
    c15b5ff View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2015

  1. Added a test case where the parsing fails for empty select box

    @pratyushmittal
    pratyushmittal committed Apr 16, 2015
    Configuration menu
    Copy the full SHA
    70da61c View commit details
    Browse the repository at this point in the history

  2. Added a fix for paring empty select boxes

    @pratyushmittal
    pratyushmittal committed Apr 16, 2015
    Configuration menu
    Copy the full SHA
    56eddb9 View commit details
    Browse the repository at this point in the history

  3. Fixed PIP Session error as suggested in other pull requests

    @pratyushmittal
    pratyushmittal committed Apr 16, 2015
    Configuration menu
    Copy the full SHA
    2ee55f9 View commit details
    Browse the repository at this point in the history

  4. The tests used to fail when the lxml library was installed: Error rai… 

    …sed InvalidNameError.

This commit ensures that the tests pass no matter the user has installed whichever parsing library with bs4.

**Explanation:**

When using lxml (recommended parser in BeautifulSoup4) the parsing is little different then the inbuilt parser:

    BeautifulSoup('<input name="hi">')
    # gives "<html><body><input name='hi' /></body></html>"
    # while the inbuilt parser gives "<input name='hi' />"
    # Thus the add_field function used to fail by giving InvalidNameError

The parsing of complicated forms is way much better using `lxml` and RoboBrowser compliments it well.
The only issue caused was due to the individual field parsings.
Forcing inbuilt parser for fields parsing fixes the issues with individual fields while ensuring the efficiency of lxml for parsing of forms.
    @pratyushmittal
    pratyushmittal committed Apr 16, 2015
    Configuration menu
    Copy the full SHA
    eee0cd8 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2015

  1. List requirements in setup file. 

    [resolves #39]
[supersedes #38]
[supersedes #37]
[supersedes #35]
[supersedes #32]
    @jmcarp
    jmcarp committed Apr 17, 2015
    Configuration menu
    Copy the full SHA
    4878ed3 View commit details
    Browse the repository at this point in the history

  2. Handle iteration error in pypy tests.

    @jmcarp
    jmcarp committed Apr 17, 2015
    Configuration menu
    Copy the full SHA
    567d3ae View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2015

  1. Merge pull request #31 from voyageur/do-not-install-tests 

    Do not install tests
    @jmcarp
    jmcarp committed Apr 18, 2015
    Configuration menu
    Copy the full SHA
    1a9aa8e View commit details
    Browse the repository at this point in the history

  2. Use cached_property for parsed HTML.

    @jmcarp
    jmcarp committed Apr 18, 2015
    Configuration menu
    Copy the full SHA
    bc9deb2 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'pratyushmittal/master'

    @jmcarp
    jmcarp committed Apr 18, 2015
    Configuration menu
    Copy the full SHA
    6587134 View commit details
    Browse the repository at this point in the history

  4. Lint with flake8.

    @jmcarp
    jmcarp committed Apr 18, 2015
    Configuration menu
    Copy the full SHA
    3b60ed0 View commit details
    Browse the repository at this point in the history

  5. Release version 0.5.2.

    @jmcarp
    jmcarp committed Apr 18, 2015
    Configuration menu
    Copy the full SHA
    f842291 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2015

  1. Add error message for selecting non-existent option in multi-option f… 

    …ield.
    @rcutmore
    rcutmore committed May 4, 2015
    Configuration menu
    Copy the full SHA
    47397be View commit details
    Browse the repository at this point in the history

Commits on May 25, 2015

  1. Don't serialize disabled inputs. 

    * Add `disabled` property on form fields.
* Exclude disabled fields from serialized output.
* Update unit tests.

[Resolves #42]
    @jmcarp
    jmcarp committed May 25, 2015
    Configuration menu
    Copy the full SHA
    c249037 View commit details
    Browse the repository at this point in the history

  2. Can't use assert_not_in in py2.6.

    @jmcarp
    jmcarp committed May 25, 2015
    Configuration menu
    Copy the full SHA
    fcf2446 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2015

  1. Allow method override on Browser#open. 

    Method defaults to "get", but can be overridden using the optional
`method` parameter.

[Resolves #27]
    @jmcarp
    jmcarp committed May 26, 2015
    Configuration menu
    Copy the full SHA
    d382f0c View commit details
    Browse the repository at this point in the history

Commits on May 27, 2015

  1. Merge remote-tracking branch 'rcutmore/add-multi-option-field-error-m… 

    …essage'
    @jmcarp
    jmcarp committed May 27, 2015
    Configuration menu
    Copy the full SHA
    e2480c4 View commit details
    Browse the repository at this point in the history

  2. Add better error messages.

    @jmcarp
    jmcarp committed May 27, 2015
    Configuration menu
    Copy the full SHA
    4bf18ee View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2015

  1. Fix default value for selects. 

    [Resolves #23]
    @jmcarp
    jmcarp committed Jun 1, 2015
    Configuration menu
    Copy the full SHA
    a3ba87a View commit details
    Browse the repository at this point in the history

  2. Simplify value properties. 

    Replace magical property creation in metaclass with explicit `@property`
and `@setter` decorators in field classes.
    @jmcarp
    jmcarp committed Jun 1, 2015
    Configuration menu
    Copy the full SHA
    a9ae952 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2015

  1. Update docs for change to Rap Genius website 

    The Genius website (formerly Rap Genius) changed, which broke the
existing documentation example. The search results now include results
matching song title as well as artist, making it difficult to guarantee
the first song would match the artist being searched for. As a result
the example was updated to search for a more unique band name.

[Resolves #33]
    @rcutmore
    rcutmore committed Jun 7, 2015
    Configuration menu
    Copy the full SHA
    06c3ae4 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #45 from rcutmore/update-docs-for-rap-genius-change 

    Update docs for change to Rap Genius website
    @jmcarp
    jmcarp committed Jun 7, 2015
    Configuration menu
    Copy the full SHA
    58b47b4 View commit details
    Browse the repository at this point in the history

  3. Document custom session options. 

    [Resolves #28]
    @jmcarp
    jmcarp committed Jun 7, 2015
    Configuration menu
    Copy the full SHA
    38d646a View commit details
    Browse the repository at this point in the history

  4. Offload retry logic to requests and urllib3. 

    Urllib3 comes with good retry logic, which is exposed through the
requests `HTTPAdapter`. Attach retry options to the session adapters and
delete custom retry logic from robobrowser.
    @jmcarp
    jmcarp committed Jun 7, 2015
    1 Configuration menu
    Copy the full SHA
    a243352 View commit details
    Browse the repository at this point in the history

  5. Bump version and update changelog.

    @jmcarp
    jmcarp committed Jun 7, 2015
    Configuration menu
    Copy the full SHA
    4284c11 View commit details
    Browse the repository at this point in the history