git-svn(zh_HANS-CN): avoid bogus file:// link
#106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way the description is currently written, there is no space after the `file://` in the translation, even if there is a space there in the original. This is important because the way AsciiDoc is parsed, a missing space will mistake the text for being an actual hyperlink, see e.g.: https://github.com/jnavila/git-html-l10n/blob/171352a71363/zh_HANS-CN/git-svn.html#L1198 At the time of writing, this bogus link can be experienced here: https://git-scm.com/docs/git-svn/zh_HANS-CN#git-svn-svn-remoteltgtrewriteRoot However, the "domain name" is quite bogus seeing as it reads, according to Bing Translate: access), but want to publish in metadata with public which is obviously not a valid domain name. Firefox is smart enough to realize that this is not a valid domain name, and "auto-fixes" it to `file:///`. However, Edge (and therefore most likely Chrome, too), as well as link checkers such as Lychee (https://lychee.cli.rs/) translate this into an internationalized domain name starting with the "ASCII-Compatible Encoding" prefix "xn--" (see https://en.wikipedia.org/wiki/Internationalized_domain_name) and is immediately followed by a closing parenthesis, which is not a valid character in internet host/domain names, but at least Lychee tries to follow it nevertheless: file://xn--),-ry2c56bzyech9a071b11ispsycrp191dutgptg8hx808c0kpb/ Let's clearly separate `file://` from the next word and avoid letting AsciiDoc mark this as a hyperlink. Signed-off-by: Johannes Schindelin <[email protected]>
|
Thanks for the report. The checks need to be muscled on this kind of issues... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the description is currently written, there is no space after the
file://in the translation, even if there is a space there in the original.This is important because the way AsciiDoc is parsed, a missing space will mistake the text for being an actual hyperlink, see e.g. here. At the time of writing, this bogus link can be experienced on Git's home page:
However, the "domain name" is quite bogus seeing as it reads, according to Bing Translate:
which is obviously not a valid domain name.
Firefox is smart enough to realize that this is not a valid domain name, and "auto-fixes" it to
file:///. However, Edge (and therefore most likely Chrome, too), as well as link checkers such as Lychee translate this into an internationalized domain name starting with the "ASCII-Compatible Encoding" prefix "xn--" which is immediately followed by a closing parenthesis, i.e. an invalid character in internet host/domain names, but at least Lychee tries to follow it nevertheless:file://xn--),-ry2c56bzyech9a071b11ispsycrp191dutgptg8hx808c0kpb/
Let's clearly separate
file://from the next word and avoid letting AsciiDoc mark this as a hyperlink.