Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes design issues in metadata panel #2009

Merged
merged 18 commits into from
Aug 13, 2024
Merged

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Jul 29, 2024

Description

Resolves #1827

Development notes

QA notes

  • Verify fixes using a screen ruler or box model
  • All tests should pass

NOTE: Lint issue will be resolved once #2029 is merged

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@ravi-kumar-pilla ravi-kumar-pilla changed the title Fix/metadata panel UI Fixes design issues in metadata panel Jul 29, 2024
Copy link
Contributor

@jitu5 jitu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stephkaiser
Copy link

thank you Ravi! it's looking great, some design QA comments from me:

  1. can we have lower-case 'p' for 'Expand preview' button
  2. the top padding for the metadata panel looks to be 40px, can we change this to 32px?
Screenshot 2024-07-31 at 18 28 36
  1. 'Show Code' toggle still seems to be slightly lower than the label, it should be positioned in the center of the label
Screenshot 2024-07-31 at 18 34 26
  1. the scrolling functionality works great! however i've noticed for data tables, when scrolling to the right the gradient is 'stuck' on the table and does not stay on the right of the preview area, see screenshot below:
Screenshot 2024-07-31 at 18 29 46
  1. the 'Copied!' tooltip that appears when the run command copy button is clicked is not aligned with the copy button anymore, can we update this as well?
Screenshot 2024-07-31 at 18 36 09
  1. could we also add more space in the bottom padding for the title? (32px below, same as top padding) Currently when scrolling content it looks like this:
Screenshot 2024-07-31 at 18 32 54 Screenshot 2024-08-01 at 16 25 45

let me know if there are any questions, thank you!!

@ravi-kumar-pilla
Copy link
Contributor Author

thank you Ravi! it's looking great, some design QA comments from me:

Hi Steph,
Thanks for the review. I fixed the review comments. Please review and let me know if there are any issues.

Copy link
Contributor

@Huongg Huongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes, LGTM 👍

@stephkaiser
Copy link

Hi Steph, Thanks for the review. I fixed the review comments. Please review and let me know if there are any issues.

Thanks Ravi, all the design QA comments above looks fixed now, well done!

I've unfortunately found more though, im sorry about that!

  1. the left and right padding looks good for the text components but if you look at the screenshot below, it seems like the X button and the copy button isn't aligned with the padding
Screenshot 2024-08-07 at 18 21 52 Screenshot 2024-08-06 at 11 55 30 Screenshot 2024-08-06 at 11 55 02
  1. I just noticed that the plotly previews still have the old button ("collapse plotly visualisation") which we removed a while ago, we only have the back button now in the top left corner
Screenshot 2024-08-07 at 18 18 53
  1. the padding between the title and the 'Show code' toggle should also be 32px
Screenshot 2024-08-06 at 11 52 35

I hope these are the last changes! sorry and thank you :)

@ravi-kumar-pilla ravi-kumar-pilla merged commit 3f53128 into main Aug 13, 2024
10 checks passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the fix/metadata-panel-ui branch August 13, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata panel design fixes
5 participants