Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes design issues in metadata panel #2009

Merged
merged 18 commits into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@
- Use present tense (e.g. 'Add new feature')
- Include the ID number for the related PR (or PRs) in parentheses
-->
# Upcoming Release

Check warning on line 8 in RELEASE.md

View workflow job for this annotation

GitHub Actions / vale

[vale] RELEASE.md#L8

[Kedro-viz.headings] 'Upcoming Release' should use sentence-style capitalization.
Raw output
{"message": "[Kedro-viz.headings] 'Upcoming Release' should use sentence-style capitalization.", "location": {"path": "RELEASE.md", "range": {"start": {"line": 8, "column": 3}}}, "severity": "WARNING"}

## Bug fixes and other changes

- Fixes design issues in metadata panel. (#2009)

# Release 9.2.0

## Major features and improvements
Expand Down
8 changes: 4 additions & 4 deletions src/components/metadata/metadata.js
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ const MetaData = ({
>
<ExpandIcon className="pipeline-metadata__link-icon"></ExpandIcon>
<span className="pipeline-metadata__link-text">
Expand Plotly Visualization
Expand Preview
</span>
</button>
</>
Expand All @@ -307,7 +307,7 @@ const MetaData = ({
>
<ExpandIcon className="pipeline-metadata__link-icon"></ExpandIcon>
<span className="pipeline-metadata__link-text">
Expand Matplotlib Image
Expand Preview
</span>
</button>
</>
Expand Down Expand Up @@ -346,7 +346,7 @@ const MetaData = ({
>
<ExpandIcon className="pipeline-metadata__link-icon"></ExpandIcon>
<span className="pipeline-metadata__link-text">
Expand Preview Table
Expand Preview
</span>
</button>
</>
Expand All @@ -369,7 +369,7 @@ const MetaData = ({
>
<ExpandIcon className="pipeline-metadata__link-icon"></ExpandIcon>
<span className="pipeline-metadata__link-text">
Expand JSON View
Expand Preview
</span>
</button>
</>
Expand Down
2 changes: 1 addition & 1 deletion src/components/metadata/styles/metadata-code.scss
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
padding: 0 variables.$metadata-sidebar-width-open 0 0;
transform: translateX(100vw);
transition: transform ease 0.5s 0.1s, left ease 0.5s;
z-index: 2;
z-index: 4;
ravi-kumar-pilla marked this conversation as resolved.
Show resolved Hide resolved

&--visible {
transform: translateX(variables.$global-toolbar-width);
Expand Down
13 changes: 6 additions & 7 deletions src/components/metadata/styles/metadata.scss
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
top: -1px; /* Avoids pixel rounding gaps */
right: -1px;
bottom: -1px;
z-index: 2;
z-index: 4;
display: flex;
flex-direction: column;
width: 100%;
Expand Down Expand Up @@ -69,15 +69,14 @@
.pipeline-metadata__header {
display: flex;
justify-content: space-between;
margin-top: -0.12em;
}

.pipeline-metadata__header-toolbox {
position: relative;
display: flex;
flex-direction: column-reverse;
justify-content: space-between;
margin: 3em 3.6em;
margin: 3.2em 3.6em;
padding-right: 24px;
}

Expand Down Expand Up @@ -261,12 +260,12 @@ $list-inline-spacing: 0.2em;
.pipeline-metadata__link-icon {
width: 1.9em;
height: 1.9em;
margin: 0 6px 0 36px;
margin: 0 0.8em 0 0;
fill: var(--color-button-text);
}

.pipeline-metadata__link-text {
margin: 12px 10px 12px 5px;
margin: 18px 0;
color: var(--color-button-text);
font-size: 1.6em;
}
Expand All @@ -281,14 +280,14 @@ $list-inline-spacing: 0.2em;
.pipeline-metadata__preview {
background: var(--color-metadata-preview-bg);
height: 300px;
overflow: hidden;
overflow: scroll;
position: relative;
}

.pipeline-metadata__preview-json {
background: var(--color-metadata-preview-bg);
height: 300px;
overflow: hidden;
overflow: scroll;
position: relative;
padding: 10px 20px 0;
}
Expand Down
1 change: 1 addition & 0 deletions src/components/ui/command-copier/command-copier.scss
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
margin-top: 0.3em;
margin-right: -0.6em;
opacity: 0.55;
padding-left: 24px;

.pipeline-icon {
width: 26px;
Expand Down
3 changes: 2 additions & 1 deletion src/components/ui/toggle/toggle.scss
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
margin-top: 0.3em;
margin-bottom: 2em;
transition: opacity 0.2s ease;
display: flex;
}

.pipeline-toggle--no-hasCode {
Expand All @@ -41,7 +42,7 @@

.pipeline-toggle-label {
position: relative;
padding: 0 0 0 2.8em;
padding: 0 0 0 2.2em;
cursor: pointer;
user-select: none;
color: var(--color-toggle-off-label);
Expand Down
Loading