Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement telemetry for commands #84

Merged
merged 21 commits into from
Sep 13, 2024
Merged

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Aug 30, 2024

Context

Fixed #68

QA Notes:

image

Dev Notes

  • Reuse kedro-telemetry for the consent
  • Run script as a tool to get consent / reuse LSP (python process) to get information about the consent
  • Store the consent in extension.
  • When Kedro: run viz or any command is triggered, send an event to HEAP using the server/client API.

@noklam noklam changed the title lsClient has been remove from webview. clean up Implement telemetry for commands Aug 30, 2024
src/extension.ts Show resolved Hide resolved
@noklam noklam marked this pull request as ready for review September 4, 2024 16:03
src/common/utilities.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
bundled/tool/check_consent.py Outdated Show resolved Hide resolved
@@ -0,0 +1,2 @@
packaging
kedro-telemetry>=0.6.0 # First version that does not prompt for telemetry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add appdirs as one more dependency for kedro-telemetry. As we are not installing all its required dependencies. I got the importError for appdirs when I was testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice found

Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
@jitu5 jitu5 merged commit a573818 into main Sep 13, 2024
2 checks passed
@jitu5 jitu5 deleted the noklam/track-command-usage-with-68 branch September 13, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track command usage with telemetry
2 participants