Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement telemetry for commands #84
Implement telemetry for commands #84
Changes from 18 commits
e22234e
4a5f140
6f4fb4b
f892037
0ee5e62
3980238
05dccd8
cc750c3
24c121f
0e8e0d6
a61a798
ea8bc1d
4421b43
a96833f
31ca44d
28bc0d5
199ef49
27c3ad2
0b6b0c0
004c82c
8214d13
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add
appdirs
as one more dependency forkedro-telemetry
. As we are not installing all its required dependencies. I got the importError forappdirs
when I was testing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice found
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.