[Bug] Have html export always use latest published version #2292
Conversation
This previous commit: keplergl@dbba7da#diff-d487565baf71f3a3554594403f1de25ce00ba6b634da5248f461f14dbddfe5c2R21 updated the version of kepler.gl to a build that is not published to unpkg.com To fix this problem and avoid in the future, I removed the specific version tag. According to https://unpkg.com/ , this means the latest published version will always be used (currently 2.5.5)
|
Sorry, I put the DCO in the PR but not the commit message. LMK if this blocks approval and I can reword the message. |
| @@ -18,7 +18,7 @@ | |||
| <script src="https://unpkg.com/[email protected]/dist/styled-components.min.js" crossorigin></script> | |||
|
|
|||
| <!-- Load Kepler.gl--> | |||
| <script src="https://unpkg.com/kepler.gl@3.0.0-alpha.0/umd/keplergl.min.js"></script> | |||
| <script src="https://unpkg.com/kepler.gl/umd/keplergl.min.js"></script> | |||
There was a problem hiding this comment.
Q: Have you confirmed if this load the latest 2.x production version or the latest alpha version? I am assuming the alpha versions are published with a tag and I seem to remember that one needs to specify the tag in the unpkg url in such cases?
I assume we want this to load the same version that is hosted on kepler.gl/demo.
@igorDykhta Any thoughts?
There was a problem hiding this comment.
When I tested this locally it loaded 2.5.5. I also browsed the available versions at https://unpkg.com/browse/kepler.gl/
I can see alpha tags for previous versions but not 3.0.0. https://kepler.gl/demo/ appears to be all compiled inside a bundle.js , so I couldn't double check the version (though I see it on the browser on the left-hand side)
My thinking was that this change would mean as soon as 3.0 is published it would be used, and in the meantime the latest version would be used which seems to be the workaround working for most folks based on past issues filed.
There was a problem hiding this comment.
confirming this works if you change the version of kepler.gl to load:
<script src="https://unpkg.com/[email protected]/umd/keplergl.min.js" crossorigin></script>
Signed-off-by: Eric Sherman [email protected]
fixes #2028 , fixes #2111, fixes #2202
This previous commit:
dbba7da#diff-d487565baf71f3a3554594403f1de25ce00ba6b634da5248f461f14dbddfe5c2R21 updated the version of kepler.gl to a build that is not published to unpkg.com
To fix this problem and avoid in the future, I removed the specific version tag. According to https://unpkg.com/ , this means the latest published version will always be used (currently 2.5.5)
Thanks for the great project!