Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Have html export always use latest published version #2292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Bug] Have html export always use latest published version #2292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/umd-client/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<script src="https://unpkg.com/[email protected]/dist/styled-components.min.js" crossorigin></script>

<!-- Load Kepler.gl-->
<script src="https://unpkg.com/kepler.gl@3.0.0-alpha.0/umd/keplergl.min.js"></script>
<script src="https://unpkg.com/kepler.gl/umd/keplergl.min.js"></script>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Have you confirmed if this load the latest 2.x production version or the latest alpha version? I am assuming the alpha versions are published with a tag and I seem to remember that one needs to specify the tag in the unpkg url in such cases?

I assume we want this to load the same version that is hosted on kepler.gl/demo.

@igorDykhta Any thoughts?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tested this locally it loaded 2.5.5. I also browsed the available versions at https://unpkg.com/browse/kepler.gl/

I can see alpha tags for previous versions but not 3.0.0. https://kepler.gl/demo/ appears to be all compiled inside a bundle.js , so I couldn't double check the version (though I see it on the browser on the left-hand side)

My thinking was that this change would mean as soon as 3.0 is published it would be used, and in the meantime the latest version would be used which seems to be the workaround working for most folks based on past issues filed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirming this works if you change the version of kepler.gl to load:

<script src="https://unpkg.com/[email protected]/umd/keplergl.min.js" crossorigin></script>

<!--If you want to load the build from filepath -->
<!--<script src="../../umd/keplergl.min.js"></script>-->

Expand Down