Clarify envoy validation api comment (#10235)

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot>
kgateway-dev · Oct 26, 2024 · b443fa1 · b443fa1
1 parent c7b49a4
commit b443fa1
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/changelog/v1.18.0-beta30/clarify-envoy-validation-api.yaml b/changelog/v1.18.0-beta30/clarify-envoy-validation-api.yaml
@@ -0,0 +1,8 @@
+changelog:
+  - type: NON_USER_FACING
+    issueLink: https://github.com/solo-io/gloo/issues/5720
+    resolvesIssue: false
+    description: >-
+      Update comment for Envoy validation API since it is now implemented
+
+      skipCI-kube-tests:true
diff --git a/...reference/api/github.com/solo-io/gloo/projects/gloo/api/v1/settings.proto.sk.md b/...reference/api/github.com/solo-io/gloo/projects/gloo/api/v1/settings.proto.sk.md
diff --git a/projects/gloo/api/v1/settings.proto b/projects/gloo/api/v1/settings.proto
@@ -916,7 +916,8 @@ message GatewayOptions {
         // validation mode. This has an negative impact on the total translation throughput, but it
         // helps ensure the configuration will not be nacked when served to Envoy.
         //
-        // This feature is not yet implemented.
+        // This feature is disabled by default and is not recommended for production deployments unless
+        // the performance implications are well understood and acceptable.
         google.protobuf.BoolValue full_envoy_validation = 14;
     }
 

diff --git a/projects/gloo/pkg/api/v1/settings.pb.go b/projects/gloo/pkg/api/v1/settings.pb.go