fix(consequence): skfp-850 use consequencescell from ferlab #3837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for portal-qa-next-kidsfirstdrc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for portal-pre-prod-kidsfirstdrc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Coverage report
Test suite run success0 tests passing in 0 suite. Report generated by 🧪jest coverage report action from 501b45b |
AltefrohneGaelle
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG
Description
Issue: It seems like we encounter an error 500 whenever we have a consequence = intergenic in the Variant Entity page. This may be because there is no gene associated to the consequence?
Variant Exploration:
If there is no gene, we should not show the label NO_GENE in the Consequence column
https://portal.includedcc.org/variants?sharedFilterId=18ffd6ee-6f51-497a-b445-95e2266b4903
Variant Entity page:
If there is no gene consequence, then we should illustrate under the Consequence Section, Gene Consequence table, the “No data available” that is used for other sections like Pathogenicity.
Screenshot
Before
After