Workshop reviewer #134
Merged
Workshop reviewer #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2024 08:38
Reviewer rules can be skipped based on conditions, and suggestions can be used in rules
Tethik
reviewed
Nov 18, 2024
core/src/validation/engine.ts
Outdated
| return await condition(ruleArgs); | ||
| }); | ||
| const results = await Promise.all(conditions); | ||
| console.log(`Conditional results: ${results}`); |
There was a problem hiding this comment.
Should not use console.log, use the logger instead (look for getLogger in the code)
Tethik
reviewed
Nov 18, 2024
| // Validate model | ||
| for (const rule of modelRules) { | ||
| if (!isModelValidation(rule)) { | ||
| continue; | ||
| } | ||
|
|
||
| if (rule.conditionalRules && rule.conditionalRules.length > 0) { |
There was a problem hiding this comment.
Missing tests to cover this new functionality
Tethik
requested changes
Nov 18, 2024
added 2 commits
November 18, 2024 15:28
also skips all snapshots
Tethik
reviewed
Nov 18, 2024
Tethik
reviewed
Nov 18, 2024
| @@ -91,4 +91,56 @@ describe("ValidationEngine", () => { | |||
|
|
|||
| expect(Array.isArray(resultList)).toBe(true); | |||
| }); | |||
|
|
|||
| it("should select rules that have no conditions", async () => { | |||
Tethik
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to skip a reviewer rule with conditions build with the model data.
It also provides rules with access to control and threat suggestions.