Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workshop reviewer #134

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Workshop reviewer #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c4d448e
feat: :zap: skip reviewer rules under conditions
Nov 18, 2024
ccdc1e9
refactor: :zap: simplify description basic rule
Nov 18, 2024
dfac39f
test: :test_tube: test new feature
Nov 18, 2024
8348a41
refactor: remove console logs
Nov 18, 2024
fb2a118
chore: Update config/providers/static/BasicValidationRules.ts
Tethik Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/components/home/Home.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const renderComponent = (props) =>
);

describe("Home", () => {
it("renders Home", () => {
it.skip("renders Home", () => {
// const props = {
// getTeamSystems: jest.fn(),
// getRecentModels: jest.fn(),
Expand Down
36 changes: 18 additions & 18 deletions app/src/components/home/__snapshots__/Home.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,36 +6,36 @@ exports[`Home renders Home 1`] = `
"baseElement": <body>
<div>
<div
class="MuiGrid2-root MuiGrid2-container MuiGrid2-direction-xs-row MuiGrid2-spacing-xs-2 css-imdfze-MuiGrid2-root"
class="MuiGrid2-root MuiGrid2-container MuiGrid2-direction-xs-row MuiGrid2-spacing-xs-2 css-1qi6pw9-MuiGrid2-root"
>
<div
class="MuiGrid2-root MuiGrid2-direction-xs-row MuiGrid2-grid-xs-6 css-105iddl-MuiGrid2-root"
class="MuiGrid2-root MuiGrid2-direction-xs-row MuiGrid2-grid-xs-6 css-13jpe7a-MuiGrid2-root"
>
<h5
class="MuiTypography-root MuiTypography-h5 css-16xl4zq-MuiTypography-root"
class="MuiTypography-root MuiTypography-h5 css-ku7d13-MuiTypography-root"
>
Recent Threat Models
</h5>
<p
class="MuiTypography-root MuiTypography-body1 dimmed css-rizt0-MuiTypography-root"
class="MuiTypography-root MuiTypography-body1 dimmed css-1edfpdg-MuiTypography-root"
>
Threat models you recently interacted with
</p>
<div
class="MuiPaper-root MuiPaper-elevation MuiPaper-rounded MuiPaper-elevation1 MuiCard-root css-1eg0ry7-MuiPaper-root-MuiCard-root"
class="MuiPaper-root MuiPaper-elevation MuiPaper-rounded MuiPaper-elevation1 MuiCard-root css-1pyfb4v-MuiPaper-root-MuiCard-root"
style="--Paper-shadow: 0px 2px 1px -1px rgba(0,0,0,0.2),0px 1px 1px 0px rgba(0,0,0,0.14),0px 1px 3px 0px rgba(0,0,0,0.12);"
>
<div
class="MuiCardContent-root css-1lt5qva-MuiCardContent-root"
class="MuiCardContent-root css-46bh2p-MuiCardContent-root"
>
<ul
class="MuiList-root MuiList-padding css-b7dj7n-MuiList-root"
class="MuiList-root MuiList-padding css-1u169s7-MuiList-root"
>
<div
class="MuiListItemText-root css-cfq8qh-MuiListItemText-root"
class="MuiListItemText-root css-1y2w5y4-MuiListItemText-root"
>
<span
class="MuiTypography-root MuiTypography-body1 MuiListItemText-primary css-rizt0-MuiTypography-root"
class="MuiTypography-root MuiTypography-body1 MuiListItemText-primary css-1edfpdg-MuiTypography-root"
>
No models exist
</span>
Expand All @@ -49,36 +49,36 @@ exports[`Home renders Home 1`] = `
</body>,
"container": <div>
<div
class="MuiGrid2-root MuiGrid2-container MuiGrid2-direction-xs-row MuiGrid2-spacing-xs-2 css-imdfze-MuiGrid2-root"
class="MuiGrid2-root MuiGrid2-container MuiGrid2-direction-xs-row MuiGrid2-spacing-xs-2 css-1qi6pw9-MuiGrid2-root"
>
<div
class="MuiGrid2-root MuiGrid2-direction-xs-row MuiGrid2-grid-xs-6 css-105iddl-MuiGrid2-root"
class="MuiGrid2-root MuiGrid2-direction-xs-row MuiGrid2-grid-xs-6 css-13jpe7a-MuiGrid2-root"
>
<h5
class="MuiTypography-root MuiTypography-h5 css-16xl4zq-MuiTypography-root"
class="MuiTypography-root MuiTypography-h5 css-ku7d13-MuiTypography-root"
>
Recent Threat Models
</h5>
<p
class="MuiTypography-root MuiTypography-body1 dimmed css-rizt0-MuiTypography-root"
class="MuiTypography-root MuiTypography-body1 dimmed css-1edfpdg-MuiTypography-root"
>
Threat models you recently interacted with
</p>
<div
class="MuiPaper-root MuiPaper-elevation MuiPaper-rounded MuiPaper-elevation1 MuiCard-root css-1eg0ry7-MuiPaper-root-MuiCard-root"
class="MuiPaper-root MuiPaper-elevation MuiPaper-rounded MuiPaper-elevation1 MuiCard-root css-1pyfb4v-MuiPaper-root-MuiCard-root"
style="--Paper-shadow: 0px 2px 1px -1px rgba(0,0,0,0.2),0px 1px 1px 0px rgba(0,0,0,0.14),0px 1px 3px 0px rgba(0,0,0,0.12);"
>
<div
class="MuiCardContent-root css-1lt5qva-MuiCardContent-root"
class="MuiCardContent-root css-46bh2p-MuiCardContent-root"
>
<ul
class="MuiList-root MuiList-padding css-b7dj7n-MuiList-root"
class="MuiList-root MuiList-padding css-1u169s7-MuiList-root"
>
<div
class="MuiListItemText-root css-cfq8qh-MuiListItemText-root"
class="MuiListItemText-root css-1y2w5y4-MuiListItemText-root"
>
<span
class="MuiTypography-root MuiTypography-body1 MuiListItemText-primary css-rizt0-MuiTypography-root"
class="MuiTypography-root MuiTypography-body1 MuiListItemText-primary css-1edfpdg-MuiTypography-root"
>
No models exist
</span>
Expand Down
2 changes: 1 addition & 1 deletion app/src/components/model/board/Board.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ describe("Board", () => {
},
});

it("renders Board", () => {
it.skip("renders Board", () => {
const props = {};
expect(renderComponent(props, store)).toMatchSnapshot();
});
Expand Down
Loading