Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

모두의 말뭉치: 형태 분석 말뭉치 loader #126

Merged
merged 7 commits into from
Oct 12, 2020
Merged

Conversation

lovit
Copy link
Member

@lovit lovit commented Oct 10, 2020

Pull Request

Korpora에 기여해 주셔서 감사합니다.

해당 Pull Request를 제출하기 전에 아래 사항이 완료되었는지 확인 부탁드립니다:

  • 작성한 코드가 어떤 에러나 경고 없이 실행이 되나요?
  • 작성한 코드에 대한 테스트 코드를 만드셨나요? (경로 : Korpora/test)
  • 기존 코드 역시 에러 없이 수행이 되겠죠?

1. 해당 PR은 어떤 내용인가요?

형태 분석 말뭉치의 loader 와 사용법

2. PR과 관련된 이슈가 있나요?

#103, #122

@lovit lovit requested a review from ratsgo October 10, 2020 20:35
@lovit lovit changed the title Dev morpheme#122 모두의 말뭉치: 형태 분석 말뭉치 loader #122 Oct 11, 2020
@lovit lovit changed the title 모두의 말뭉치: 형태 분석 말뭉치 loader #122 모두의 말뭉치: 형태 분석 말뭉치 loader Oct 11, 2020
return examples


def load_modu_ne(paths):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

load_modu_morpheme의 오타겠지요?
수정 커밋 해두겠습니다

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오타 교정 감사합니다

'VX': '보조용언',
'VCP': '긍정지정사',
'VCN': '부정지정사',
'MMA': '관형사',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

국립국어원 태그표에 따르면 성상 관형사로 해야 정확할거 같습니다. 수정 커밋해둘게요.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정 확인했습니다. 감사합니다.

Copy link
Member

@ratsgo ratsgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 결과 이상없이 동작함을 확인했습니다.
고생 많으셨어요!

@lovit lovit merged commit 4c0d672 into dev Oct 12, 2020
@lovit lovit deleted the dev-morpheme#122 branch October 12, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants