feat(helpBubble): add Academy link and update text of existing links TASK-1466 #5437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duvld
approved these changes
Jan 28, 2025
| @@ -217,6 +217,12 @@ | |||
| env.str('KOBO_SUPPORT_URL', 'https://support.kobotoolbox.org/'), | |||
| 'URL for "KoboToolbox Help Center"', | |||
| ), | |||
| 'ACADEMY_URL': ( | |||
There was a problem hiding this comment.
Curious why do we need to check the environment for these links?
There was a problem hiding this comment.
I just followed the same code for the other URLs. But yeah, maybe it's not necessary for this one
| @@ -316,7 +317,7 @@ def test_free_tier_override_uses_organization_owner_join_date( | |||
| def test_social_apps(self): | |||
| # GET mutates state, call it first to test num queries later | |||
| self.client.get(self.url, format='json') | |||
| queries = FuzzyInt(18, 27) | |||
| queries = FuzzyInt(18, 28) | |||
There was a problem hiding this comment.
Why this change? Not disagreeing with it but I'm just not sure where this is coming from
There was a problem hiding this comment.
I think this checks how many things are there in environment endpoint, and since we've added one, it needs to be increased:)
There was a problem hiding this comment.
Yes, a new constance configuration parameter brings an additional DB query
magicznyleszek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📣 Summary
Add new link to KoboToolbox Academy in the
HelpBubblepopup. The link is configurable through/adminUI (constance). Two existing links in the same popup had their text updated.💭 Notes
Before --> after:
👀 Preview steps
Feature/no-change template: