-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helpBubble): add Academy link and update text of existing links TASK-1466 #5437
Changes from all commits
5325029
457273f
4fb65ef
8b7c629
2fcbea3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,6 +55,7 @@ def setUp(self): | |
'source_code_url': constance.config.SOURCE_CODE_URL, | ||
'support_email': constance.config.SUPPORT_EMAIL, | ||
'support_url': constance.config.SUPPORT_URL, | ||
'academy_url': constance.config.ACADEMY_URL, | ||
'community_url': constance.config.COMMUNITY_URL, | ||
'frontend_min_retry_time': constance.config.FRONTEND_MIN_RETRY_TIME, | ||
'frontend_max_retry_time': constance.config.FRONTEND_MAX_RETRY_TIME, | ||
|
@@ -316,7 +317,7 @@ def test_free_tier_override_uses_organization_owner_join_date( | |
def test_social_apps(self): | ||
# GET mutates state, call it first to test num queries later | ||
self.client.get(self.url, format='json') | ||
queries = FuzzyInt(18, 27) | ||
queries = FuzzyInt(18, 28) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why this change? Not disagreeing with it but I'm just not sure where this is coming from There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this checks how many things are there in environment endpoint, and since we've added one, it needs to be increased:) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, a new constance configuration parameter brings an additional DB query |
||
with self.assertNumQueries(queries): | ||
response = self.client.get(self.url, format='json') | ||
self.assertEqual(response.status_code, status.HTTP_200_OK) | ||
|
@@ -335,7 +336,7 @@ def test_social_apps(self): | |
def test_social_apps_no_custom_data(self): | ||
SocialAppCustomData.objects.all().delete() | ||
self.client.get(self.url, format='json') | ||
queries = FuzzyInt(18, 27) | ||
queries = FuzzyInt(18, 28) | ||
with self.assertNumQueries(queries): | ||
response = self.client.get(self.url, format='json') | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why do we need to check the environment for these links?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just followed the same code for the other URLs. But yeah, maybe it's not necessary for this one