-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to aws-sdk-go-v2 #120
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Michael Shen <[email protected]>
Signed-off-by: Michael Shen <[email protected]>
It was providing a client-side rate limiter that is now built-in functionality in aws-sdk-go-v2 Signed-off-by: Michael Shen <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mjlshen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mjlshen: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to keep this code as similar to the original version as possible, but there are two considerations I ran into that I'm happy to implement if reviewers think they're better
- It may make more sense to use
errors.As
to filter errors instead of switching on the error code https://aws.github.io/aws-sdk-go-v2/docs/handling-errors/#api-error-responses - The
smithy.APIError
type has anErrorFault
method that classifies certain errors as client/server/unknown faults https://pkg.go.dev/github.com/aws/smithy-go#ErrorFault. This could be used instead of maintaining our own list of client-fault error codes.
This PR switches the codebase from aws-sdk-go to aws-sdk-go-v2 due to aws-sdk-go going EoL next year https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/
For the most part, it is faithful to the original code, some differences to highlight:
httputil
package was removed from this codebase - it was providing an implementation of a client-side rate limiter that is now built-in functionality in aws-sdk-go-v2.CredentialsChainVerboseErrors
option was removed in aws-sdk-go-v2 What happened to CredentialsChainVerboseErrors? aws/aws-sdk-go-v2#98Fixes #117