Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add flag --etcd-quota-backend-size #1221

Merged
merged 1 commit into from
Sep 14, 2024
Merged

add flag --etcd-quota-backend-size #1221

merged 1 commit into from
Sep 14, 2024

Conversation

logica0419
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allows for controlling the quota size of etcd.

Which issue(s) this PR fixes:

Fixes #864
(ref #866 )

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[kwokctl] Add flag --etcd-quota-backend-size

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 13, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @logica0419!

It looks like this is your first PR to kubernetes-sigs/kwok 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kwok has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. kind/documentation Categorizes issue or PR as related to documentation. labels Sep 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @logica0419. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 13, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 13, 2024 •
edited
Loading

✅ Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 442325b
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/66e59f8330cd900008937313

@logica0419
Copy link
Contributor Author

logica0419 commented Sep 13, 2024 •
edited
Loading

The test-kwok-e2e failed, but the reason was the "context deadline exceeded".
Thus, I assume it will pass the test by rerunning.

wzshiming
wzshiming reviewed Sep 14, 2024
View reviewed changes
Copy link
Member

@wzshiming wzshiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

pkg/apis/config/v1alpha1/kwokctl_configuration_types.go Outdated Show resolved Hide resolved
pkg/kwokctl/components/etcd.go Outdated Show resolved Hide resolved
pkg/kwokctl/runtime/kind/kind.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 14, 2024
@logica0419
Copy link
Contributor Author

All fixed!

@wzshiming
Copy link
Member

Please squash all commits

@logica0419
Copy link
Contributor Author

test-kwok-e2e is a little flaky, so I guess we should extend the time limit of cluster building.

@logica0419
Copy link
Contributor Author

Done!

@wzshiming
Copy link
Member

Thank you

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logica0419, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit dbf1cca into kubernetes-sigs:main Sep 14, 2024
28 checks passed
@wzshiming
Copy link
Member

test-kwok-e2e is a little flaky, so I guess we should extend the time limit of cluster building.

I don't know the exact cause yet. When I have some free time, I'll find it and fix it.

@logica0419
Copy link
Contributor Author

Thanks!

@logica0419 logica0419 deleted the support-etcd-size-mutation branch September 15, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

@wzshiming wzshiming Awaiting requested review from wzshiming

Assignees

@wzshiming wzshiming

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support increasing the etcd size limit
3 participants
@logica0419 @k8s-ci-robot @wzshiming