Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Added words to added.txt and spelling.txt #11100

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

marcoagpinto
Copy link
Member

@marcoagpinto marcoagpinto commented Dec 11, 2024

Added a few words.

Summary by CodeRabbit

  • New Features

    • Added new entries to the Portuguese part-of-speech dictionary, enhancing language support.
    • Expanded the spelling resource with a wide range of new words, including colloquial expressions and various categories.
  • Bug Fixes

    • No existing entries were affected, ensuring stability in the language tool's functionality.

Copy link
Contributor

coderabbitai bot commented Dec 11, 2024

Warning

Rate limit exceeded

@marcoagpinto has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 34 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between c319868 and ac9cb8e.

📒 Files selected for processing (2)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/added.txt (2 hunks)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/spelling.txt (3 hunks)

Walkthrough

This pull request introduces new entries to the Portuguese part-of-speech dictionary and spelling resource files. Specifically, two new entries are added to added.txt, while spelling.txt sees a significant expansion with numerous new words, including terms from various categories. The changes enhance the vocabulary and comprehensiveness of the language tools without altering existing entries or file structures.

Changes

File Path Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/added.txt Added two new entries: videogravação videogravação NCFS000 and videogravações videogravação NCFP000.
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/spelling.txt Added extensive new entries including terms like trolls, videogravação, eternização, and many others.

Possibly related PRs

Suggested reviewers

  • jaumeortola

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between ab06593 and c319868.

📒 Files selected for processing (2)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/added.txt (1 hunks)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/spelling.txt (1 hunks)

@@ -377,3 +377,14 @@ Tolstoy
mg
peixe-dourado
peixes-dourados
trolls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Move "trolls" to the foreign words section

The word "trolls" is an English word and should be placed in the questionable foreign words section at the top of the file, not in the Portuguese words section.

Comment on lines 381 to 390
eternização
eternizações
videogravação
videogravações
cosupervisor
cosupervisores
gratinada
gratinadas
uníssona
uníssonas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider proper word categorization and alphabetical sorting

The newly added Portuguese words (eternização, videogravação, etc.) should not be in the questionable foreign words file as they are proper Portuguese terms. Consider:

  1. Moving these words to a more appropriate dictionary file
  2. If they must remain here, sort them alphabetically with other Portuguese entries

Would you like me to help identify a more suitable location for these Portuguese words in the language tool's dictionary structure?

Comment on lines +255 to +256
videogravação videogravação NCFS000
videogravações videogravação NCFP000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Missing part-of-speech entries for new words

The words "eternização", "cosupervisor", and "cosupervisores" are present in spelling.txt but missing their corresponding part-of-speech entries in added.txt. These entries should be added to maintain consistency in the dictionary:

  • Add entry for "eternização" (feminine singular noun)
  • Add entries for "cosupervisor" (masculine singular noun) and "cosupervisores" (masculine plural noun)
🔗 Analysis chain

LGTM! Verify other related words

The entries for "videogravação" are properly formatted with correct part-of-speech tags. However, since we have other new words in spelling.txt (eternização, cosupervisor, etc.), consider adding their part-of-speech information here as well for completeness.

Let's check if there are any existing entries for similar compound words:


Let me check for the other words mentioned in the review comment to verify if they need part-of-speech entries.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for similar compound words with 'video' prefix
rg "^video" languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/

Length of output: 898


Script:

#!/bin/bash
# Search for the other new words in both spelling.txt and added.txt
echo "=== Checking spelling.txt for mentioned words ==="
rg "^(eternização|cosupervisor)" languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/spelling.txt

echo -e "\n=== Checking added.txt for mentioned words ==="
rg "^(eternização|cosupervisor)" languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/added.txt

Length of output: 512

@marcoagpinto marcoagpinto merged commit 724e47a into master Dec 11, 2024
5 checks passed
@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20241211_1915 branch December 11, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant