-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pt] Added words to added.txt and spelling.txt #11100
Conversation
Warning Rate limit exceeded@marcoagpinto has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 34 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThis pull request introduces new entries to the Portuguese part-of-speech dictionary and spelling resource files. Specifically, two new entries are added to Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/added.txt
(1 hunks)languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/spelling.txt
(1 hunks)
@@ -377,3 +377,14 @@ Tolstoy | |||
mg | |||
peixe-dourado | |||
peixes-dourados | |||
trolls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Move "trolls" to the foreign words section
The word "trolls" is an English word and should be placed in the questionable foreign words section at the top of the file, not in the Portuguese words section.
eternização | ||
eternizações | ||
videogravação | ||
videogravações | ||
cosupervisor | ||
cosupervisores | ||
gratinada | ||
gratinadas | ||
uníssona | ||
uníssonas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider proper word categorization and alphabetical sorting
The newly added Portuguese words (eternização, videogravação, etc.) should not be in the questionable foreign words file as they are proper Portuguese terms. Consider:
- Moving these words to a more appropriate dictionary file
- If they must remain here, sort them alphabetically with other Portuguese entries
Would you like me to help identify a more suitable location for these Portuguese words in the language tool's dictionary structure?
videogravação videogravação NCFS000 | ||
videogravações videogravação NCFP000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Missing part-of-speech entries for new words
The words "eternização", "cosupervisor", and "cosupervisores" are present in spelling.txt but missing their corresponding part-of-speech entries in added.txt. These entries should be added to maintain consistency in the dictionary:
- Add entry for "eternização" (feminine singular noun)
- Add entries for "cosupervisor" (masculine singular noun) and "cosupervisores" (masculine plural noun)
🔗 Analysis chain
LGTM! Verify other related words
The entries for "videogravação" are properly formatted with correct part-of-speech tags. However, since we have other new words in spelling.txt (eternização, cosupervisor, etc.), consider adding their part-of-speech information here as well for completeness.
Let's check if there are any existing entries for similar compound words:
Let me check for the other words mentioned in the review comment to verify if they need part-of-speech entries.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for similar compound words with 'video' prefix
rg "^video" languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/
Length of output: 898
Script:
#!/bin/bash
# Search for the other new words in both spelling.txt and added.txt
echo "=== Checking spelling.txt for mentioned words ==="
rg "^(eternização|cosupervisor)" languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/spelling.txt
echo -e "\n=== Checking added.txt for mentioned words ==="
rg "^(eternização|cosupervisor)" languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/added.txt
Length of output: 512
Added a few words.
Summary by CodeRabbit
New Features
Bug Fixes