Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Added words to added.txt and spelling.txt #11100

Merged
merged 3 commits into from
Dec 11, 2024
Merged

[pt] Added words to added.txt and spelling.txt #11100

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c319868
[pt] Added words to added.txt and spelling.txt
marcoagpinto Dec 11, 2024
97797c1
[pt] Sorted alphabetically Marco's words
marcoagpinto Dec 11, 2024
ac9cb8e
[pt] Added missing word
marcoagpinto Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/added.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,4 +252,5 @@ Tolstoy Tolstoy NPMS000
Tolstoy Tolstoy NPMSS00
peixe-dourado peixe-dourado NCMS000
peixes-dourados peixe-dourado NCMP000

videogravação videogravação NCFS000
videogravações videogravação NCFP000
Comment on lines +253 to +254
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Missing part-of-speech entries for new words

The words "eternização", "cosupervisor", and "cosupervisores" are present in spelling.txt but missing their corresponding part-of-speech entries in added.txt. These entries should be added to maintain consistency in the dictionary:

  • Add entry for "eternização" (feminine singular noun)
  • Add entries for "cosupervisor" (masculine singular noun) and "cosupervisores" (masculine plural noun)
🔗 Analysis chain

LGTM! Verify other related words

The entries for "videogravação" are properly formatted with correct part-of-speech tags. However, since we have other new words in spelling.txt (eternização, cosupervisor, etc.), consider adding their part-of-speech information here as well for completeness.

Let's check if there are any existing entries for similar compound words:

Let me check for the other words mentioned in the review comment to verify if they need part-of-speech entries.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for similar compound words with 'video' prefix
rg "^video" languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/

Length of output: 898

Script:

#!/bin/bash
# Search for the other new words in both spelling.txt and added.txt
echo "=== Checking spelling.txt for mentioned words ==="
rg "^(eternização|cosupervisor)" languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/spelling.txt

echo -e "\n=== Checking added.txt for mentioned words ==="
rg "^(eternização|cosupervisor)" languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/added.txt

Length of output: 512

11 changes: 11 additions & 0 deletions ...uagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/spelling.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,3 +377,14 @@ Tolstoy
mg
peixe-dourado
peixes-dourados
trolls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Move "trolls" to the foreign words section

The word "trolls" is an English word and should be placed in the questionable foreign words section at the top of the file, not in the Portuguese words section.

eternização
eternizações
videogravação
videogravações
cosupervisor
cosupervisores
gratinada
gratinadas
uníssona
uníssonas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider proper word categorization and alphabetical sorting

The newly added Portuguese words (eternização, videogravação, etc.) should not be in the questionable foreign words file as they are proper Portuguese terms. Consider:

  1. Moving these words to a more appropriate dictionary file
  2. If they must remain here, sort them alphabetically with other Portuguese entries

Would you like me to help identify a more suitable location for these Portuguese words in the language tool's dictionary structure?

Loading