Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Added AP and exception to rule ID:PHD_TESE_PROCURAR_PROVAR_PROVARA #11188

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

marcoagpinto
Copy link
Member

@marcoagpinto marcoagpinto commented Jan 13, 2025

Fixed tons of false positives.

Summary by CodeRabbit

  • New Features
    • Enhanced Portuguese language rule for detecting verb usage patterns
    • Added new antipattern and examples related to the verb "quer"
    • Expanded rule coverage for language processing accuracy

Copy link
Contributor

coderabbitai bot commented Jan 13, 2025

Walkthrough

The pull request modifies the Portuguese language module's style rules in the style.xml file. The changes focus on enhancing the linguistic rule set for the verb "quer" (wants), introducing a new antipattern and expanding existing patterns. The modifications include adding new examples, broadening the exception scope for certain patterns, and refining the rule's coverage for more accurate language processing.

Changes

File Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml - Added new antipattern for "quer" + infinitive
- Expanded example entries under the new antipattern
- Updated exception scope from postag='PD.+' to `postag='PD.+

Possibly related PRs

Suggested reviewers

  • jaumeortola

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9812a95 and 612e039.

📒 Files selected for processing (1)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (3)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/style.xml (3)

10743-10762: Well-structured antipattern with comprehensive examples!

The new antipattern effectively captures valid uses of "quer" followed by infinitive verbs, which will help reduce false positives. The examples provided are diverse and represent natural language usage.


10766-10766: Verify the impact of the extended exception scope.

The addition of |RN to the exception scope will help reduce false positives. However, it would be helpful to have example sentences demonstrating the specific cases this change addresses.

Could you provide example sentences that were previously flagged as false positives but are now correctly handled with this change?


10781-10785: Good addition of negative construction examples!

These examples effectively demonstrate valid uses of negative constructions with "quer saber", which will help ensure the rule doesn't generate false positives for these common patterns.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@marcoagpinto marcoagpinto merged commit 86fdf24 into master Jan 13, 2025
5 checks passed
@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20250113_1634 branch January 13, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant