[pt] Small fix in disambiguation.xml #11196
Conversation
WalkthroughThe pull request modifies the Portuguese language disambiguation rules in the LanguageTool project. The changes focus on improving verb and token disambiguation within the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (1)
3878-3883: Fix indentation of the disambig action.The indentation of the
<disambig>element is incorrect and should align with the<pattern>element.- <disambig action="add"><wd pos='VMIP3S0'/></disambig> + <disambig action="add"><wd pos='VMIP3S0'/></disambig>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java-kotlin)
| <rule> <!-- #3 --> | ||
| <pattern> | ||
| <token>outra</token> | ||
| <marker> | ||
| <token regexp='no'>vale</token> <!-- Add verbs as found --> | ||
| </marker> | ||
| <token postag='SPS.+|RG' postag_regexp='yes'/> | ||
| </pattern> | ||
| <disambig action="add"><wd pos='VMM02S0'/></disambig> |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Remove duplicate rule.
This rule appears to be a duplicate of the previous one, with identical pattern and only a different verb form tag. Consider merging them into a single rule by adding both verb form tags.
- <rule> <!-- #3 -->
- <pattern>
- <token>outra</token>
- <marker>
- <token regexp='no'>vale</token> <!-- Add verbs as found -->
- </marker>
- <token postag='SPS.+|RG' postag_regexp='yes'/>
- </pattern>
- <disambig action="add"><wd pos='VMM02S0'/></disambig>Then modify the previous rule to include both verb forms:
<rule> <!-- #2 -->
<pattern>
<token>outra</token>
<marker>
<token regexp='no'>vale</token> <!-- Add verbs as found -->
</marker>
<token postag='SPS.+|RG' postag_regexp='yes'/>
</pattern>
- <disambig action="add"><wd pos='VMIP3S0'/></disambig>
+ <disambig action="add">
+ <wd pos='VMIP3S0'/>
+ <wd pos='VMM02S0'/>
+ </disambig>Committable suggestion skipped: line range outside the PR's diff.
There was a problem hiding this comment.
The bot's suggestion didn't work.
There was a problem hiding this comment.
@marcoagpinto I apologize for my incorrect suggestion. You were right to keep these as separate rules. Having distinct rules for each verb form (VMIP3S0 and VMM02S0) is actually clearer and more maintainable. The split approach also ensures proper disambiguation handling for each specific verb form. Please keep the rules separate as you originally implemented them.
¯\( ◕ ᴗ ◕ )/¯
✏️ Learnings added
Learnt from: marcoagpinto
PR: languagetool-org/languagetool#11196
File: languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml:3884-3892
Timestamp: 2025-01-17T08:46:06.295Z
Learning: In Portuguese disambiguation rules, when handling multiple verb forms for the same pattern, use separate rules for each verb form tag instead of combining them with multiple <wd> tags in a single rule.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
Small fix in the disambiguator.
Summary by CodeRabbit