Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Small fix in disambiguation.xml #11196

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[pt] Small fix in disambiguation.xml #11196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion ...ol-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3875,7 +3875,21 @@ USA
</marker>
<token postag='SPS.+|RG' postag_regexp='yes'/>
</pattern>
<disambig action="add"><wd pos='VMIP3S0|VMM02S0'/></disambig>
<disambig action="add"><wd pos='VMIP3S0'/></disambig>
<!--
Examples:
Um pouco de bondade de uma pessoa para outra vale mais que todo o amor pela humanidade.
-->
</rule>
<rule> <!-- #3 -->
<pattern>
<token>outra</token>
<marker>
<token regexp='no'>vale</token> <!-- Add verbs as found -->
</marker>
<token postag='SPS.+|RG' postag_regexp='yes'/>
</pattern>
<disambig action="add"><wd pos='VMM02S0'/></disambig>
Comment on lines +3884 to +3892
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Remove duplicate rule.

This rule appears to be a duplicate of the previous one, with identical pattern and only a different verb form tag. Consider merging them into a single rule by adding both verb form tags.

-    <rule> <!-- #3 -->
-      <pattern>
-        <token>outra</token>
-        <marker>
-          <token regexp='no'>vale</token> <!-- Add verbs as found -->
-        </marker>
-        <token postag='SPS.+|RG' postag_regexp='yes'/>
-      </pattern>
-      <disambig action="add"><wd pos='VMM02S0'/></disambig>

Then modify the previous rule to include both verb forms:

     <rule> <!-- #2 -->
       <pattern>
         <token>outra</token>
         <marker>
           <token regexp='no'>vale</token> <!-- Add verbs as found -->
         </marker>
         <token postag='SPS.+|RG' postag_regexp='yes'/>
       </pattern>
-      <disambig action="add"><wd pos='VMIP3S0'/></disambig>
+      <disambig action="add">
+        <wd pos='VMIP3S0'/>
+        <wd pos='VMM02S0'/>
+      </disambig>

Committable suggestion skipped: line range outside the PR's diff.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bot's suggestion didn't work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcoagpinto I apologize for my incorrect suggestion. You were right to keep these as separate rules. Having distinct rules for each verb form (VMIP3S0 and VMM02S0) is actually clearer and more maintainable. The split approach also ensures proper disambiguation handling for each specific verb form. Please keep the rules separate as you originally implemented them.

¯\( ◕ ᴗ ◕ )/¯

✏️ Learnings added 
Learnt from: marcoagpinto
PR: languagetool-org/languagetool#11196
File: languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml:3884-3892
Timestamp: 2025-01-17T08:46:06.295Z
Learning: In Portuguese disambiguation rules, when handling multiple verb forms for the same pattern, use separate rules for each verb form tag instead of combining them with multiple <wd> tags in a single rule.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

<!--
Examples:
Um pouco de bondade de uma pessoa para outra vale mais que todo o amor pela humanidade.
Expand Down
Loading