Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative base path respective to config file #237

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

samirsilwal
Copy link
Collaborator

@samirsilwal samirsilwal commented Oct 11, 2024

closes #225

Changes

  • Update base path to be relative to sync-db config file location
  • Update name extraction condition
  • Update default value for base path

Test

  • directory structure
    image
  1. CMD yarn sync-db migrate-list --config=./src/sync-db.yml
    image

  2. CMD yarn sync-db migrate-rollback --config=./src/sync-db.yml
    image

  3. CMD yarn sync-db migrate-latest --config=$(pwd)/src/sync-db.yml
    image

  4. CMD yarn sync-db synchronize --config=$(pwd)/src/sync-db.yml
    image

  5. CMD yarn sync-db make test_update_example --config=$(pwd)/src/sync-db.yml
    image

  • directory structure 2
    image
  1. CMD yarn sync-db migrate-list --config=./sync-db.yml
    image

  2. CMD yarn sync-db migrate-rollback --config=./sync-db.yml
    image

  3. CMD yarn sync-db migrate-latest --config=$(pwd)/sync-db.yml
    image

  4. CMD yarn sync-db synchronize --config=$(pwd)/sync-db.yml
    image

@samirsilwal
Copy link
Collaborator Author

I think there some issue with codecov 🤔 saw in somewhere else as well

@mesaugat
Copy link
Member

@samirsilwal The codecov package is deprecated. We should remove that dependency and use the codecov github action instead.

@mesaugat mesaugat merged commit 82ee723 into master Oct 15, 2024
3 of 5 checks passed
@mesaugat mesaugat deleted the feat/fix-relative-path branch October 15, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve the basePath relative to the sync-db.yml path instead of current working directory.
3 participants