Drop unrequired params for QUIC and WebRTC interop tests #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
changed the title
marten-seemann
approved these changes
Jan 27, 2023
jxs
force-pushed
the
drop-unrequired-params
branch
from
3b48a93
to
344b10b
Compare
thomaseizinger
approved these changes
Jan 29, 2023
MarcoPolo
reviewed
Jan 31, 2023
| @@ -121,8 +121,8 @@ export async function buildTestSpecs(versions: Array<Version>): Promise<Array<Co | |||
| dialerID: test.id1, | |||
| listenerID: test.id2, | |||
| transport: test.transport, | |||
| muxer: "webrtc", | |||
| security: "webrtc", | |||
| muxer: "", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #106
Had this on the pipeline @MarcoPolo, feel free to close if you prefer to address everything after #117 gets merged