Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unrequired params for QUIC and WebRTC interop tests #118

Closed
wants to merge 1 commit into from
Closed

Drop unrequired params for QUIC and WebRTC interop tests #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions multidim-interop/go/v0.22/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func main() {
options = append(options, libp2p.Security(libp2ptls.ID, libp2ptls.New))
case "noise":
options = append(options, libp2p.Security(noise.ID, noise.New))
case "quic":
case "":
default:
panic("Unsupported secure channel")
}
Expand All @@ -99,7 +99,7 @@ func main() {
options = append(options, libp2p.Muxer("/yamux/1.0.0", yamux.DefaultTransport))
case "mplex":
options = append(options, libp2p.Muxer("/mplex/6.7.0", mplex.DefaultTransport))
case "quic":
case "":
default:
panic("Unsupported muxer")
}
Expand Down
4 changes: 2 additions & 2 deletions multidim-interop/go/v0.23/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ func main() {
options = append(options, libp2p.Security(libp2ptls.ID, libp2ptls.New))
case "noise":
options = append(options, libp2p.Security(noise.ID, noise.New))
case "quic":
case "":
default:
panic("Unsupported secure channel")
}
Expand All @@ -103,7 +103,7 @@ func main() {
options = append(options, libp2p.Muxer("/yamux/1.0.0", yamux.DefaultTransport))
case "mplex":
options = append(options, libp2p.Muxer("/mplex/6.7.0", mplex.DefaultTransport))
case "quic":
case "":
default:
panic("Unsupported muxer")
}
Expand Down
4 changes: 2 additions & 2 deletions multidim-interop/go/v0.24/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func main() {
options = append(options, libp2p.Security(libp2ptls.ID, libp2ptls.New))
case "noise":
options = append(options, libp2p.Security(noise.ID, noise.New))
case "quic":
case "":
default:
panic("Unsupported secure channel")
}
Expand All @@ -106,7 +106,7 @@ func main() {
options = append(options, libp2p.Muxer("/yamux/1.0.0", yamux.DefaultTransport))
case "mplex":
options = append(options, libp2p.Muxer("/mplex/6.7.0", mplex.DefaultTransport))
case "quic":
case "":
default:
panic("Unsupported muxer")
}
Expand Down
10 changes: 5 additions & 5 deletions multidim-interop/src/generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ export async function buildTestSpecs(versions: Array<Version>): Promise<Array<Co
dialerID: test.id1,
listenerID: test.id2,
transport: test.transport,
muxer: "quic",
security: "quic",
muxer: "",
security: "",
extraEnv: buildExtraEnv(timeoutOverride, test.id1, test.id2)
})))
.concat(webrtcQueryResults
Expand All @@ -121,8 +121,8 @@ export async function buildTestSpecs(versions: Array<Version>): Promise<Array<Co
dialerID: test.id1,
listenerID: test.id2,
transport: test.transport,
muxer: "webrtc",
security: "webrtc",
muxer: "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this in #121

security: "",
extraEnv: buildExtraEnv(timeoutOverride, test.id1, test.id2)
})))

Expand Down Expand Up @@ -166,4 +166,4 @@ function buildSpec(containerImages: { [key: string]: string }, { name, dialerID,

function normalizeTransport(transport: string | { name: string, onlyDial: boolean }): { name: string, onlyDial: boolean } {
return typeof transport === "string" ? { name: transport, onlyDial: false } : transport
}
}