Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace file reading/writing with interprocess queues for tests #912

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

MarkZH
Copy link
Collaborator

@MarkZH MarkZH commented Feb 14, 2024

Type of pull request:

  • Bug fix
  • Feature
  • Other

Description:

Instead of reading and writing files to communicate between the various processes during testing, use multiprocessing managed queues to send chess objects. This is much simpler than serializing and deserializing text. There is no chance for any test to overwrite communication from a different test.

Related Issues:

N/A

Checklist:

  • I have read and followed the contribution guidelines.
  • I have added necessary documentation (if applicable).
  • The changes pass all existing tests.

Screenshots/logs (if applicable):

N/A

Instead of reading and writing files to communicate between
the various processes during testing, use multiprocessing
managed queues to send chess objects. This is much simpler
than serializing and deserializing text. There is no chance for
any test to overwrite communication from a different test.
@AttackingOrDefending
Copy link
Member

I think a comment making it obvious that lichess-bot plays black in tests should be included.

@AttackingOrDefending AttackingOrDefending merged commit 4c133b6 into lichess-bot-devs:master Feb 16, 2024
15 checks passed
@MarkZH MarkZH deleted the threaded-testing branch February 16, 2024 18:33
@MarkZH MarkZH mentioned this pull request Feb 17, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants