LPD-46949 Fix failing test about tabs not being localized in Frontend Data Set Sample #4739

antonio-ortega · 2025-02-18T20:31:10Z

Hi,

In order to fix LPD-46949 the first commit is enough. That test started failing when we moved from liferay-ui:tabs to clay:navigation-bar. Since those tabs are not part of Frontend Data Set itself, it's enough to search for original name 'Classic'.

Apart from that and after talking to @dsanz , I've also moved from Poshi to Playwright the rest of tests in the second commit since they were relatively straightforward.

There are still a pair of .testcase files in the same folder we should migrate.

Thanks.

liferay-continuous-integration · 2025-02-18T20:31:16Z

CI is automatically triggering the following test suites:

ci:test:sf

liferay-continuous-integration · 2025-02-18T20:35:19Z

❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1aef8c7c1f29d044950b1c2ace31c81be0af0bed

Sender Branch:

Branch Name: LPD-46949
Branch GIT ID: b341e4827ddac69e5d09e438ba87ce791f3ca5f1

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

     [exec] > Task :packageRunCheckFormat
     [exec] yarn run v1.13.0
     [exec] \$ node-scripts check:ci
     [exec] 
     [exec] ⚙️ Running preflight checks...
     [exec] 
     [exec] ⚙️ Checking outdated tsconfig.json files ...
     [exec] 
     [exec] ⚙️ Running TypeScript checks on modified files...
     [exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers
     [exec] 
     [exec] ⚙️ Running format checks on modified files...
     [exec]    /opt/dev/projects/github/liferay-portal/modules/test/playwright/tests/frontend-data-set-web/classic.spec.ts
     [exec]      27:64  error  Expected object keys to be in natural ascending order. 'locale' should be before 'site'.  sort-keys
     [exec]      29:2  error  'fdsSamplePageURL' is assigned a value but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
     [exec]      1:1  error  File has format errors.  (format check)
     [exec]    
     [exec]    ✖ 3 problems (3 errors, 0 warnings)
     [exec]    
     [exec]    
     [exec] ❌ CI checks failed.
     [exec] 
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':packageRunCheckFormat'.
     [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] > Run with --info or --debug option to get more log output.
     [exec] > Run with --scan to get full insights.
     [exec] > Get more help at https://help.gradle.org.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'.
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$1(ExecuteActionsTaskExecuter.java:148)
     [exec]   at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:282)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:146)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:134)
     [exec]   at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)

liferay-continuous-integration · 2025-02-18T20:37:34Z

Jenkins Build:test-portal-source-format#7472

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#4739

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - antonio-ortega > liferay-frontend - PR#4739 - 2025-02-18[12:31:23]

Testray Build ID:144738512

Testray Importer:publish-testray-report#27475

antonio-ortega · 2025-02-19T08:19:25Z

ci:test:sf

liferay-continuous-integration · 2025-02-19T08:25:20Z

❌ ci:test:sf - 0 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1aef8c7c1f29d044950b1c2ace31c81be0af0bed

Sender Branch:

Branch Name: LPD-46949
Branch GIT ID: 047802b8a70f3774e66813570e24dd345c4a1deb

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

     [exec] > Task :packageRunCheckFormat
     [exec] yarn run v1.13.0
     [exec] \$ node-scripts check:ci
     [exec] 
     [exec] ⚙️ Running preflight checks...
     [exec] 
     [exec] ⚙️ Checking outdated tsconfig.json files ...
     [exec] 
     [exec] ⚙️ Running TypeScript checks on modified files...
     [exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers
     [exec] 
     [exec] ⚙️ Running format checks on modified files...
     [exec]    /opt/dev/projects/github/liferay-portal/modules/test/playwright/tests/frontend-data-set-web/classic.spec.ts
     [exec]      27:64  error  Expected object keys to be in natural ascending order. 'locale' should be before 'site'.  sort-keys
     [exec]      29:2  error  'fdsSamplePageURL' is assigned a value but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
     [exec]    
     [exec]    ✖ 2 problems (2 errors, 0 warnings)
     [exec]    
     [exec]    
     [exec] ❌ CI checks failed.
     [exec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
     [exec] error Command failed with exit code 1.
     [exec] 
     [exec] > Task :packageRunCheckFormat FAILED
     [exec] 
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':packageRunCheckFormat'.
     [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] > Run with --info or --debug option to get more log output.
     [exec] > Run with --scan to get full insights.
     [exec] > Get more help at https://help.gradle.org.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'.
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$1(ExecuteActionsTaskExecuter.java:148)
     [exec]   at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:282)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:146)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:134)

liferay-continuous-integration · 2025-02-19T08:28:04Z

Jenkins Build:test-portal-source-format#6723

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#4739

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - antonio-ortega > liferay-frontend - PR#4739 - 2025-02-19[00:20:23]

Testray Build ID:145088010

Testray Importer:publish-testray-report#26058

antonio-ortega · 2025-02-19T08:38:05Z

ci:test:sf

liferay-continuous-integration · 2025-02-19T08:46:30Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 8 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1aef8c7c1f29d044950b1c2ace31c81be0af0bed

Sender Branch:

Branch Name: LPD-46949
Branch GIT ID: a3399251b0c70edabca6469e7ae2fe2f7482b569

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2025-02-19T08:49:52Z

Jenkins Build:test-portal-source-format#6255

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#4739

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - antonio-ortega > liferay-frontend - PR#4739 - 2025-02-19[00:38:45]

Testray Build ID:145095994

Testray Importer:publish-testray-report#7031

antonio-ortega · 2025-02-19T09:12:54Z

ci:test:relevant

liferay-continuous-integration · 2025-02-19T10:29:18Z

✔️ ci:test:stable - 24 out of 24 jobs passed

❌ ci:test:relevant - 29 out of 32 jobs passed in 1 hour 11 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1aef8c7c1f29d044950b1c2ace31c81be0af0bed

Upstream Comparison:

Branch GIT ID: 1aef8c7c1f29d044950b1c2ace31c81be0af0bed
Jenkins Build URL: EE Development Acceptance (master) - 1197 - 2025-02-18[12:37:20]

ci:test:stable - 24 out of 24 jobs PASSED

24 Successful Jobs:

ci:test:relevant - 29 out of 32 jobs PASSED

3 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~
central-requirements
- central-requirements/0/0
functional-smoke-tomcat90-mysql57_stable
- functional-smoke-tomcat90-mysql57_stable/0/0
functional-upgrade-tomcat90-mysql57_stable
js-unit
- js-unit/0/0
- js-unit/1/0
modules-compile
modules-integration-mysql57
- modules-integration-mysql57/0/0
modules-integration-mysql57_stable
- modules-integration-mysql57_stable/0/0
modules-semantic-versioning
- modules-semantic-versioning/0/0
modules-unit
- modules-unit/0/0
modules-unit_stable
- modules-unit_stable/0/0
playwright-js-tomcat90-mysql57
playwright-js-tomcat90-mysql57_stable
- playwright-js-tomcat90-mysql57_stable/0/0
unit_stable
- unit_stable/0/0

29 Successful Jobs:

For more details click here.

Failures unique to this pull:

playwright-js-tomcat90-mysql57/0/0 - Playwright Report
1. frontend-data-set-web/customized.spec.ts
  Check behavior of item actions

Failures in common with acceptance upstream results at 1aef8c7:

playwright-js-tomcat90-mysql57/2/1 - Playwright Report

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz

liferay-continuous-integration · 2025-02-19T10:36:22Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#11043

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-frontend#4739

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - antonio-ortega > liferay-frontend - PR#4739 - 2025-02-19[01:17:09]

Testray Build ID:145120299

Testray Importer:publish-testray-report#24423

liferay-continuous-integration · 2025-02-28T16:06:33Z

✔️ ci:test:stable - 24 out of 24 jobs passed

❌ ci:test:relevant - 29 out of 32 jobs passed in 2 hours 28 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a3eeae509ec5c5299f93d233cf94f3f2e7b64129

Upstream Comparison:

Branch GIT ID: 55d1ceb821cd4bbb0be8f65278556eeb45a6983a
Jenkins Build URL: EE Development Acceptance (master) - 1209 - 2025-02-25[08:38:59]

ci:test:stable - 24 out of 24 jobs PASSED

24 Successful Jobs:

ci:test:relevant - 29 out of 32 jobs PASSED

3 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~
central-requirements
- central-requirements/0/0
functional-smoke-tomcat90-mysql57_stable
- functional-smoke-tomcat90-mysql57_stable/0/0
functional-upgrade-tomcat90-mysql57_stable
js-unit
- js-unit/0/0
- js-unit/1/0
modules-compile
modules-integration-mysql57
- modules-integration-mysql57/0/0
modules-integration-mysql57_stable
- modules-integration-mysql57_stable/0/0
modules-semantic-versioning
- modules-semantic-versioning/0/0
modules-unit
- modules-unit/0/0
modules-unit_stable
- modules-unit_stable/0/0
playwright-js-tomcat90-mysql57
playwright-js-tomcat90-mysql57_stable
- playwright-js-tomcat90-mysql57_stable/0/0
unit_stable
- unit_stable/0/0

29 Successful Jobs:

For more details click here.

Failures unique to this pull:

playwright-js-tomcat90-mysql57/0/0 - Playwright Report
1. frontend-data-set-web/customized.spec.ts
  Check behavior of item actions

Failures in common with acceptance upstream results at 55d1ceb:

playwright-js-tomcat90-mysql57/2/1 - Playwright Report
1. frontend-data-set-admin-web/tests/data-set-fragment/dataSets.spec.ts
  "Data Set" fragment can display different sources of data: StructuredContentSchema, UserSchema, TaxonomyVocabularySchema

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz

liferay-continuous-integration · 2025-02-28T16:11:56Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#7464

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-frontend#4739

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - antonio-ortega > liferay-frontend - PR#4739 - 2025-02-28[05:36:58]

Testray Build ID:153306953

Testray Importer:publish-testray-report#16264

juanjofgliferay

LGTM 🚀

antonio-ortega · 2025-03-06T09:36:18Z

ci:test:relevant

liferay-continuous-integration · 2025-03-06T10:40:53Z

✔️ ci:test:stable - 24 out of 24 jobs passed

❌ ci:test:relevant - 29 out of 32 jobs passed in 1 hour 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8ac9b6c56f56b6f3222ee196435d8d27932ef50a

Upstream Comparison:

Branch GIT ID: 8ac9b6c56f56b6f3222ee196435d8d27932ef50a
Jenkins Build URL: EE Development Acceptance (master) - 1214 - 2025-03-05[16:35:47]

ci:test:stable - 24 out of 24 jobs PASSED

24 Successful Jobs:

ci:test:relevant - 29 out of 32 jobs PASSED

3 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~
central-requirements
- central-requirements/0/0
functional-smoke-tomcat90-mysql57_stable
- functional-smoke-tomcat90-mysql57_stable/0/0
functional-upgrade-tomcat90-mysql57_stable
js-unit
- js-unit/0/0
- js-unit/1/0
modules-compile
modules-integration-mysql57
- modules-integration-mysql57/0/0
modules-integration-mysql57_stable
- modules-integration-mysql57_stable/0/0
modules-semantic-versioning
- modules-semantic-versioning/0/0
modules-unit
- modules-unit/0/0
modules-unit_stable
- modules-unit_stable/0/0
playwright-js-tomcat90-mysql57
playwright-js-tomcat90-mysql57_stable
- playwright-js-tomcat90-mysql57_stable/0/0
unit_stable
- unit_stable/0/0

29 Successful Jobs:

For more details click here.

Failures unique to this pull:

playwright-js-tomcat90-mysql57/0/0 - Playwright Report
1. frontend-data-set-web/customized.spec.ts
  Check behavior of item actions

Failures in common with acceptance upstream results at 8ac9b6c:

playwright-js-tomcat90-mysql57/2/1 - Playwright Report
1. frontend-data-set-admin-web/tests/data-set-fragment/dataSets.spec.ts
  "Data Set" fragment can display different sources of data: StructuredContentSchema, UserSchema, TaxonomyVocabularySchema
2. frontend-data-set-admin-web/tests/data-set-fragment/creationActions.spec.ts
  Creation Actions in Data Set fragment › Show the Creation Actions menu if more than one Creation Action is defined

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz

liferay-continuous-integration · 2025-03-06T10:45:55Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#12920

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-frontend#4739

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - antonio-ortega > liferay-frontend - PR#4739 - 2025-03-06[01:36:31]

Testray Build ID:157945730

Testray Importer:publish-testray-report#27712

dsanz · 2025-03-07T07:51:30Z

I've put this on hold because we're about to send #4779 which renames customized to advanced

antonio-ortega requested a review from liferay-frontend as a code owner February 18, 2025 20:31

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - failure and removed ci:test:sf - pending labels Feb 18, 2025

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - failure and removed ci:test:sf - failure ci:test:sf - pending labels Feb 19, 2025

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - failure ci:test:sf - pending labels Feb 19, 2025

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Feb 19, 2025

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - success and removed ci:test:stable - success ci:test:relevant - pending ci:test:stable - pending labels Feb 28, 2025

juanjofgliferay approved these changes Mar 4, 2025

View reviewed changes

antonio-ortega added 5 commits March 6, 2025 10:35

LPD-46949 Migrate test from Poshi to Playwright

ce0fa92

LPD-46949 These tests can also be moved to Playwright

c349ce6

LPD-46949 Create a function to reuse in every item action

ef50829

LPD-46949 SF

6f52194

LPD-46949 SF

b91c1c6

antonio-ortega force-pushed the LPD-46949 branch from a339925 to b91c1c6 Compare March 6, 2025 09:36

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - failure ci:test:stable - success ci:test:relevant - pending ci:test:stable - pending labels Mar 6, 2025

dsanz added the ⌛ On hold label Mar 7, 2025

dsanz mentioned this pull request Mar 7, 2025

LPD-49651 Create Playwright test for frontendDataSetQuickActions #4767

Open

LPD-46949 Fix failing test about tabs not being localized in Frontend Data Set Sample #4739

Are you sure you want to change the base?

LPD-46949 Fix failing test about tabs not being localized in Frontend Data Set Sample #4739

Conversation

antonio-ortega commented Feb 18, 2025

liferay-continuous-integration commented Feb 18, 2025

liferay-continuous-integration commented Feb 18, 2025

❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

liferay-continuous-integration commented Feb 18, 2025

antonio-ortega commented Feb 19, 2025

liferay-continuous-integration commented Feb 19, 2025

❌ ci:test:sf - 0 out of 1 jobs passed in 5 minutes

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

liferay-continuous-integration commented Feb 19, 2025

antonio-ortega commented Feb 19, 2025

liferay-continuous-integration commented Feb 19, 2025

✔️ ci:test:sf - 1 out of 1 jobs passed in 8 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Feb 19, 2025

antonio-ortega commented Feb 19, 2025

liferay-continuous-integration commented Feb 19, 2025

✔️ ci:test:stable - 24 out of 24 jobs passed

❌ ci:test:relevant - 29 out of 32 jobs passed in 1 hour 11 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-continuous-integration commented Feb 19, 2025

liferay-continuous-integration commented Feb 28, 2025

✔️ ci:test:stable - 24 out of 24 jobs passed

❌ ci:test:relevant - 29 out of 32 jobs passed in 2 hours 28 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-continuous-integration commented Feb 28, 2025

juanjofgliferay left a comment

Choose a reason for hiding this comment

antonio-ortega commented Mar 6, 2025

liferay-continuous-integration commented Mar 6, 2025

✔️ ci:test:stable - 24 out of 24 jobs passed

❌ ci:test:relevant - 29 out of 32 jobs passed in 1 hour 3 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-continuous-integration commented Mar 6, 2025

dsanz commented Mar 7, 2025