LPD-45919 Remove plugins/codesnippetgeshi/dev directory #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markocikos
reviewed
Jan 21, 2025
There was a problem hiding this comment.
Intead of making a huge change on the patch file, can we just exclude this dir from production build? See what I did for samples in #220. Patch is just a line in build configuration, the rest of the PR is deletion of cashed built files, that you'll see after ./ck.sh build
|
New version for this pull request can be found in #222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Since https://nvd.nist.gov/vuln/detail/cve-2024-43407 was reported, I'm following the same approach CKEditor did to fix it removing codesnippetgeshi/dev directory.
Thanks.