LPD-45919 Remove plugins/codesnippetgeshi so it is not shipped in our liferay-ckeditor

[antonio-ortega]

Previous pull requeest

As suggested here rather than creating a huge patch, we can do the same just removing that directory when building liferay-ckeditor.

[markocikos]

@antonio-ortega please see comments inside

[markocikos]

This is inventive, but not exactly what I had in mind. With this, we would first make a production build, that includes unwanted dir, and delete that dir after. A better solution is to exclude unwanted dir from production build itself, so it's not added in the first place. We can do this by adding exclusion pattern to CKBUILDER_CONFIG in build-config.js. That's what I did in #220, adding samples string to ignore array. Note that there is a version of this file in both dev subrepo and main repo, as the build copies the config file itself. It may be safe to delete file in main repo, but I wasn't sure, so I just updated it in both places.

Is the intent to remove codesnippetgeshi/dev dir, or the whole plugin? If it's dev dir, I am noticing dev is already in the exclusion list, and codesnippetgeshi/dev is already not added to production build. If the intent is to remove the whole plugin, just adding codesnippetgeshi to exclusion list should do it. Is this safe to remove the whole plugin?

[antonio-ortega]

That's a really good point! I hadn't noticed we are already removing dev folder from plugin, which is exactly the way how CKEditor addressed this case.

Having a look at their current master branch, where this is issue is considered fixed, they still have that plugin.js file.

Based on that, I think we are not vulnerable to this issue and we can close this pull request.

Thanks.

Regards.

[markocikos]

I am not sure what generated this change, but it looks wrong and is probably causing the CI failure.