Add mintV2 loadtest
#1285
Open
Add mintV2 loadtest
#1285
+227
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12997637530Details
💛 - Coveralls |
With the new mintV2 test we add a few extra parameters to the config file. In this PR we expose the new parameters in the sample config and add them to the config struct definition.
We make the WaitForNTxsInMempool function public as it's going to be needed in the mintV2 loadtest.
We add a new mintV2 test which mints normal assets of a configured supply into a fixed number of groups. This is an enhanced and more lightweight version of the previous mint test, as it uses less assertions and rpc calls.
GeorgeTsagk
force-pushed
the
loadtest-mint-v2
branch
from
b444e01 to
964f42c
Compare
guggero
approved these changes
Jan 29, 2025
|
|
||
| var assetRequests []*mintrpc.MintAssetRequest | ||
|
|
||
| t.Logf("Minting %v assets into group %s", cfg.BatchSize, tweakedKey) |
| mintNewGroup(t, ctx, bitcoinClient, minter, cfg) | ||
| } | ||
|
|
||
| // If there's not any existing groups we skip the rest of the steps, we |
There was a problem hiding this comment.
grammar nit: "If there aren't any existing groups".
| } | ||
|
|
||
| // nolint:lll | ||
| assetRequests := []*mintrpc.MintAssetRequest{ |
There was a problem hiding this comment.
nit: can remove a level of indentation by formatting as:
assetRequests := []*mintrpc.MintAssetRequest{{
Asset: &mintrpc.MintAsset{
AssetType: taprpc.AssetType_NORMAL,
Name: fmt.Sprintf(
"tapcoin-%d", time.Now().UnixNano(),
),
AssetMeta: &taprpc.AssetMeta{
Data: []byte("{}"),
Type: taprpc.AssetMetaType_META_TYPE_JSON,
},
Amount: mintAmt,
NewGroupedAsset: true,
DecimalDisplay: 4,
},
}}
That way we don't need the lll nolint directive. Same below.
| defer cancel() | ||
|
|
||
| finalizeReq := &mintrpc.FinalizeBatchRequest{} | ||
| // Instruct the daemon to finalize the batch. |
There was a problem hiding this comment.
nit: newline before comment block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a lighter version of the mintTest, which also uses a few more configuration parameters to control how minting occurs. We now mint normal assets into a fixed total number of groups.
This was originally intended as a rewrite of the existing mint test, but it is introduced as a totally separate function. We could keep both functions and even try to run them in parallel at some point.
The minter is fixed to Alice node, as Bob could not mint into a group that is controlled by Alice. So fixing this role to Alice makes things much simpler.