NodeProvider has a client pool to re-use connections #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christos-h
commented
Sep 23, 2024
afck
approved these changes
Sep 24, 2024
afck
reviewed
Sep 24, 2024
| @@ -32,14 +39,22 @@ impl ValidatorNodeProvider for NodeProvider { | |||
|
|
|||
| fn make_node(&self, address: &str) -> anyhow::Result<Self::Node, NodeError> { | |||
| let address = address.to_lowercase(); | |||
| let mut pool = self.client_pool.lock().unwrap(); | |||
| if let Some(client) = pool.get(&address) { | |||
| return Ok(client.clone()); | |||
There was a problem hiding this comment.
Do both clients handle reconnecting if the other side dropped the connection?
There was a problem hiding this comment.
Exactly. This needs to be tested
ma2bd
requested changes
Oct 23, 2024
| pub struct NodeProvider { | ||
| grpc: GrpcNodeProvider, | ||
| #[cfg(with_simple_network)] | ||
| simple: SimpleNodeProvider, | ||
| client_pool: Arc<Mutex<HashMap<String, Client>>>, |
There was a problem hiding this comment.
Based on the experience of #2664, the GrpcNodeProvider should instead include a HashMap<String, tonic::transport::Channel>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Clients are instantiating connections multiple times to validators instead of re-using connections resulting in re-negotiating TLS and general unecessary network overhead.
Proposal
Add a pool of clients to
NodeProviderwhich can be re-used.This decreases end-to-end operation latency by 10%-35% depending on the RTT between client and committee.
Test Plan
The existing tests will catch regressions. Below are some ad-hoc benchmarks: