-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NodeProvider has a client pool to re-use connections #2527
Open
christos-h
wants to merge
1
commit into
linera-io:main
Choose a base branch
from
christos-h:node-provider-client-pool
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,11 @@ | ||
// Copyright (c) Zefchain Labs, Inc. | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
use std::{ | ||
collections::HashMap, | ||
sync::{Arc, Mutex}, | ||
}; | ||
|
||
use linera_base::time::Duration; | ||
use linera_core::node::{NodeError, ValidatorNodeProvider}; | ||
|
||
|
@@ -10,11 +15,12 @@ use crate::{client::Client, grpc::GrpcNodeProvider}; | |
|
||
/// A general node provider which delegates node provision to the underlying | ||
/// node provider according to the `ValidatorPublicNetworkConfig`. | ||
#[derive(Copy, Clone)] | ||
#[derive(Clone)] | ||
pub struct NodeProvider { | ||
grpc: GrpcNodeProvider, | ||
#[cfg(with_simple_network)] | ||
simple: SimpleNodeProvider, | ||
client_pool: Arc<Mutex<HashMap<String, Client>>>, | ||
} | ||
|
||
impl NodeProvider { | ||
|
@@ -23,6 +29,7 @@ impl NodeProvider { | |
grpc: GrpcNodeProvider::new(options), | ||
#[cfg(with_simple_network)] | ||
simple: SimpleNodeProvider::new(options), | ||
client_pool: Default::default(), | ||
} | ||
} | ||
} | ||
|
@@ -32,14 +39,22 @@ impl ValidatorNodeProvider for NodeProvider { | |
|
||
fn make_node(&self, address: &str) -> anyhow::Result<Self::Node, NodeError> { | ||
let address = address.to_lowercase(); | ||
let mut pool = self.client_pool.lock().unwrap(); | ||
ma2bd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
if let Some(client) = pool.get(&address) { | ||
return Ok(client.clone()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do both clients handle reconnecting if the other side dropped the connection? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Exactly. This needs to be tested |
||
} | ||
|
||
#[cfg(with_simple_network)] | ||
if address.starts_with("tcp") || address.starts_with("udp") { | ||
return Ok(Client::Simple(self.simple.make_node(&address)?)); | ||
let client = Client::Simple(self.simple.make_node(&address)?); | ||
pool.insert(address, client.clone()); | ||
return Ok(client); | ||
} | ||
|
||
if address.starts_with("grpc") { | ||
return Ok(Client::Grpc(self.grpc.make_node(&address)?)); | ||
let client = Client::Grpc(self.grpc.make_node(&address)?); | ||
pool.insert(address, client.clone()); | ||
return Ok(client); | ||
} | ||
|
||
Err(NodeError::CannotResolveValidatorAddress { address }) | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the experience of #2664, the
GrpcNodeProvider
should instead include aHashMap<String, tonic::transport::Channel>