Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Subword assignment support via rewriting to read-modify-write #3658

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

[FIRRTL] Subword assignment support via rewriting to read-modify-write #3658

wants to merge 54 commits into from
+673 −98

Commits on Aug 29, 2022

  1. Eliminate bit-index during expand-whens

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    9a16fad View commit details
    Browse the repository at this point in the history

  2. Fix builder insertion point ordering

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    729a577 View commit details
    Browse the repository at this point in the history

  3. Move transformation to separate function

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    8bd876a View commit details
    Browse the repository at this point in the history

  4. Initialization checking

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    98bc0c4 View commit details
    Browse the repository at this point in the history

  5. Comments and clarify implementation

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    bf0853e View commit details
    Browse the repository at this point in the history

  6. Memoize initialization reachability check

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    c61b5dd View commit details
    Browse the repository at this point in the history

  7. Fix null operand in comb cycles

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    1a19152 View commit details
    Browse the repository at this point in the history

  8. Single int subscript support

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    56114a2 View commit details
    Browse the repository at this point in the history

  9. Range index parsing

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    68fa8a0 View commit details
    Browse the repository at this point in the history

  10. Move canonicalizations to firrtl folds

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    2e564f8 View commit details
    Browse the repository at this point in the history

  11. Add some subword assignment tests

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    8dfee61 View commit details
    Browse the repository at this point in the history

  12. Fix initialization checking and add test

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    9aa4a56 View commit details
    Browse the repository at this point in the history

  13. Fix for SInt

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    0940fba View commit details
    Browse the repository at this point in the history

  14. Remove redundant test

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    8632e5f View commit details
    Browse the repository at this point in the history

  15. Fix typo

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    6ffc360 View commit details
    Browse the repository at this point in the history

  16. Improve wording around uninitialized wires

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    da54006 View commit details
    Browse the repository at this point in the history

  17. Auto format

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    dbae003 View commit details
    Browse the repository at this point in the history

  18. Make flow same as parent op

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    2ddfb84 View commit details
    Browse the repository at this point in the history

  19. Add parser and flow tests

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    f4e231b View commit details
    Browse the repository at this point in the history

  20. Restructure parser to avoid needing lookahead

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    258cfa0 View commit details
    Browse the repository at this point in the history

  21. Improve comments

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    4408b2f View commit details
    Browse the repository at this point in the history

  22. Update more comments

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    83f2a56 View commit details
    Browse the repository at this point in the history

  23. Skip subword initialization checking entirely if unused

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    a95efb9 View commit details
    Browse the repository at this point in the history

  24. Use replaceOpWithNewOpAndCopyName

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    e505573 View commit details
    Browse the repository at this point in the history

  25. Remove braces for single line if statements

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    a6dfb07 View commit details
    Browse the repository at this point in the history

  26. Add e2e test

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    f430e94 View commit details
    Browse the repository at this point in the history

  27. Improve canonicalizations

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    824ee37 View commit details
    Browse the repository at this point in the history

  28. Test comment

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    0030d29 View commit details
    Browse the repository at this point in the history

  29. Comment wrapping

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    23dd0f0 View commit details
    Browse the repository at this point in the history

  30. Format

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    b6e781b View commit details
    Browse the repository at this point in the history

  31. Use DenseSet for cache

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    6cdd494 View commit details
    Browse the repository at this point in the history

  32. Remove debug

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    f45729f View commit details
    Browse the repository at this point in the history

  33. Remove recursion in initialization checking

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    b6c0f8d View commit details
    Browse the repository at this point in the history

  34. Remove dead code from test

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    6ef1bd5 View commit details
    Browse the repository at this point in the history

  35. Add canonicalization tests

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    a34fd1b View commit details
    Browse the repository at this point in the history

  36. Add LHS bits canonicalization

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    b4f7851 View commit details
    Browse the repository at this point in the history

  37. Remove recursion in canonicalizeBits

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    3bebbf6 View commit details
    Browse the repository at this point in the history

  38. Format

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    134e1ad View commit details
    Browse the repository at this point in the history

  39. Fix bug in initialization checking with subwordUninit set

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    da7d08e View commit details
    Browse the repository at this point in the history

  40. Auto format

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    0ae0295 View commit details
    Browse the repository at this point in the history

  41. Tidy

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    3929bd2 View commit details
    Browse the repository at this point in the history

  42. Handle bits in getDeclarationKind

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    61994ba View commit details
    Browse the repository at this point in the history

  43. Remove canonicalizations from FIRRTLFolds

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    fcee9dc View commit details
    Browse the repository at this point in the history

  44. Undo canonicalization tests now that they have been removed

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    6e7d49c View commit details
    Browse the repository at this point in the history

  45. Canonicalize through asSInt

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    d7d90ee View commit details
    Browse the repository at this point in the history

  46. Comment

    @zyedidia
    zyedidia committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    b1a1af2 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Helpful error message for CHIRRTL mem bit-index

    @zyedidia
    zyedidia committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    2bbbbab View commit details
    Browse the repository at this point in the history

  2. Add better sint test

    @zyedidia
    zyedidia committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    a60e178 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Add chirrtl mem error test

    @zyedidia
    zyedidia committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    a429b0e View commit details
    Browse the repository at this point in the history

  2. Revert "Remove canonicalizations from FIRRTLFolds" 

    This reverts commit fcee9dc.
    @zyedidia
    zyedidia committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    4e3230c View commit details
    Browse the repository at this point in the history

  3. Revert "Undo canonicalization tests now that they have been removed" 

    This reverts commit 6e7d49c.
    @zyedidia
    zyedidia committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    01ba8fc View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. Pass by reference

    @zyedidia
    zyedidia committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    3acda81 View commit details
    Browse the repository at this point in the history

  2. Additional canonicalization and fold for optimizing invalid values

    @zyedidia
    zyedidia committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    0cd42fe View commit details
    Browse the repository at this point in the history

  3. Add test for invalid value optimization

    @zyedidia
    zyedidia committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    b25575e View commit details
    Browse the repository at this point in the history