records: truncate embed values possibly exceeding field limit

lokka30 · Oct 23, 2024 · 528e116 · 528e116
1 parent b3ec817
commit 528e116
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 7 deletions.
diff --git a/src/main/kotlin/space/lachy/lachsbot/database/mongo/collection/RecordMessageDelete.kt b/src/main/kotlin/space/lachy/lachsbot/database/mongo/collection/RecordMessageDelete.kt
@@ -5,6 +5,7 @@ import org.bson.BsonDateTime
 import org.bson.codecs.pojo.annotations.BsonId
 import org.bson.codecs.pojo.annotations.BsonProperty
 import org.bson.types.ObjectId
+import space.lachy.lachsbot.util.StringExtensions.truncate
 import java.awt.Color
 import java.util.*
 
@@ -56,7 +57,7 @@ data class RecordMessageDelete(
         return EmbedBuilder()
             .setTitle("Message Deleted")
             .setDescription("Discord's API does not advise who caused this, use Audit Log to check.")
-            .addField("Last Known Message Raw", messageRawLastKnown ?: "N/A", false)
+            .addField("Last Known Message Raw", messageRawLastKnown?.truncate() ?: "N/A", false)
             .addField("Message ID", "$messageId", true)
             .addField("Timestamp Epoch", "${timestampEpoch.value}", true)
             .addField("Timestamp FMT", "${Date(timestampEpoch.value)}", true)

diff --git a/src/main/kotlin/space/lachy/lachsbot/database/mongo/collection/RecordMessageReceived.kt b/src/main/kotlin/space/lachy/lachsbot/database/mongo/collection/RecordMessageReceived.kt
@@ -1,11 +1,13 @@
 package space.lachy.lachsbot.database.mongo.collection
 
 import net.dv8tion.jda.api.EmbedBuilder
+import net.dv8tion.jda.api.entities.MessageEmbed.VALUE_MAX_LENGTH
 import org.bson.BsonDateTime
 import org.bson.codecs.pojo.annotations.BsonId
 import org.bson.codecs.pojo.annotations.BsonProperty
 import org.bson.types.ObjectId
 import space.lachy.lachsbot.listener.record.RecordListenerManager
+import space.lachy.lachsbot.util.StringExtensions.truncate
 import java.awt.Color
 import java.util.*
 
@@ -59,7 +61,7 @@ data class RecordMessageReceived(
     fun toEmbedBuilder(): EmbedBuilder {
         val builder = EmbedBuilder()
             .setTitle("Message Received")
-            .addField("Message", messageRaw, false)
+            .addField("Message", messageRaw.truncate(VALUE_MAX_LENGTH), false)
             .addField("Message ID", "$messageId", true)
             .addField("Timestamp Epoch", "${timestampEpoch.value}", true)
             .addField("Timestamp FMT", "${Date(timestampEpoch.value)}", true)
@@ -72,7 +74,7 @@ data class RecordMessageReceived(
             .addField("Author Username", authorUsername, true)
             .addField("Author Effective Name", authorEffectiveName, true)
             .addField("Author Tag", "<@${authorId}>", true)
-            .addField("Jump URL", jumpUrl, true)
+            .addField("Jump URL", jumpUrl.truncate(VALUE_MAX_LENGTH), true)
             .setFooter("${javaClass.simpleName} - ID#$id")
             .setColor(Color.LIGHT_GRAY)
 

diff --git a/src/main/kotlin/space/lachy/lachsbot/database/mongo/collection/RecordMessageUpdate.kt b/src/main/kotlin/space/lachy/lachsbot/database/mongo/collection/RecordMessageUpdate.kt
@@ -6,6 +6,7 @@ import org.bson.codecs.pojo.annotations.BsonId
 import org.bson.codecs.pojo.annotations.BsonProperty
 import org.bson.types.ObjectId
 import space.lachy.lachsbot.listener.record.RecordListenerManager
+import space.lachy.lachsbot.util.StringExtensions.truncate
 import java.awt.Color
 import java.util.*
 
@@ -65,8 +66,8 @@ data class RecordMessageUpdate(
     fun toEmbedBuilder(): EmbedBuilder {
         val builder = EmbedBuilder()
             .setTitle("Message Updated")
-            .addField("New Message Raw", messageRawNew, false)
-            .addField("Old Message Raw Last Known", messageRawLastKnown ?: "N/A", false)
+            .addField("New Message Raw", messageRawNew.truncate(), false)
+            .addField("Old Message Raw Last Known", messageRawLastKnown?.truncate() ?: "N/A", false)
             .addField("Message ID", "$messageId", true)
             .addField("Timestamp Epoch", "${timestampEpoch.value}", true)
             .addField("Timestamp FMT", "${Date(timestampEpoch.value)}", true)
@@ -81,7 +82,7 @@ data class RecordMessageUpdate(
             .addField("Author Username", authorUsername, true)
             .addField("Author Effective Name", authorEffectiveName, true)
             .addField("Author Tag", "<@${authorId}>", true)
-            .addField("Jump URL", jumpUrl, true)
+            .addField("Jump URL", jumpUrl.truncate(), true)
             .setFooter("${javaClass.simpleName} - ID#$id")
             .setColor(Color.LIGHT_GRAY)
 

diff --git a/src/main/kotlin/space/lachy/lachsbot/listener/record/RecordListenerManager.kt b/src/main/kotlin/space/lachy/lachsbot/listener/record/RecordListenerManager.kt
@@ -19,6 +19,7 @@ import space.lachy.lachsbot.listener.record.delegate.MessageReceivedRecordListen
 import space.lachy.lachsbot.listener.record.delegate.MessageUpdateRecordListener
 import space.lachy.lachsbot.listener.record.delegate.StatusChangeRecordListener
 import space.lachy.lachsbot.listener.record.delegate.UserUpdateOnlineStatusRecordListener
+import space.lachy.lachsbot.util.StringExtensions.truncate
 
 object RecordListenerManager {
 
@@ -82,7 +83,7 @@ object RecordListenerManager {
         for(att in attachments) {
             builder.addField(
                 "Attachment ${i}",
-                "Name: '${att.name}'; Extension: '${att.extension}'; URL: '${att.url}'",
+                "Name: '${att.name}'; Extension: '${att.extension}'; URL: '${att.url}'".truncate(),
                 false
             )
 

diff --git a/src/main/kotlin/space/lachy/lachsbot/util/StringExtensions.kt b/src/main/kotlin/space/lachy/lachsbot/util/StringExtensions.kt
@@ -1,9 +1,19 @@
 package space.lachy.lachsbot.util
 
+import kotlin.math.min
+
 object StringExtensions {
 
     private val humps = "(?<=.)(?=\\p{Upper})".toRegex()
 
     fun String.toSnakeCase() = replace(humps, "_").lowercase()
 
+    fun String.truncate(newLength: Int): String {
+        if(isEmpty() || newLength <= 3 || length <= newLength) {
+            return this
+        }
+
+        return take(min(length, newLength) - 3) + "..."
+    }
+
 }