-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add lb3 example application #2803
Conversation
0d56867
to
5e7c493
Compare
241ccbc
to
47c8184
Compare
examples/lb3-application/src/__tests__/acceptance/lb3app.acceptance.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The changes look mostly good, I have a couple of important comments regarding test robustness in regards to timing and automigration of LB3 models. The remaining comments are mostly stylistic.
examples/lb3-application/lb3app/server/boot/create-sample-models.js
Outdated
Show resolved
Hide resolved
examples/lb3-application/src/__tests__/acceptance/lb3app.acceptance.ts
Outdated
Show resolved
Hide resolved
examples/lb3-application/src/__tests__/acceptance/lb3app.acceptance.ts
Outdated
Show resolved
Hide resolved
examples/lb3-application/src/__tests__/acceptance/lb3app.acceptance.ts
Outdated
Show resolved
Hide resolved
examples/lb3-application/src/__tests__/acceptance/lb3app.acceptance.ts
Outdated
Show resolved
Hide resolved
examples/lb3-application/src/__tests__/acceptance/lb3app.acceptance.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall, I've tried out the steps and left some feedback for instructions.
examples/lb3-application/src/__tests__/acceptance/lb3app.acceptance.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are making great progress 👏
examples/lb3-application/lb3app/server/boot/create-sample-models.js
Outdated
Show resolved
Hide resolved
examples/lb3-application/src/__tests__/acceptance/lb3app.acceptance.ts
Outdated
Show resolved
Hide resolved
61e4f5b
to
6c571c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please get approval from other reviewers before landing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
This an example showing how to add an existing LoopBack 3 application to a LoopBack 4 project. Co-authored-by: Miroslav Bajtoš <[email protected]>
Closes #2392.
Implements a new example illustrating how the
booter-lb3app
package'sLb3AppBooterComponent
works for mounting a LoopBack 3 application in a LoopBack 4 project.Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated👉 Check out how to submit a PR 👈