[dv] Avoid imports into class scope #26002
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marnovandermaas
approved these changes
Jan 24, 2025
This construct isn't technically allowed by the SystemVerilog spec (which explicitly says it is illegal to put an import at the top of a class scope). At least one EDA tool (Questa) reports an error from this code. Move the import to the tasks where it is needed. Signed-off-by: Rupert Swarbrick <[email protected]>
This construct isn't technically allowed by the SystemVerilog spec (which explicitly says it is illegal to put an import at the top of a class scope). At least one EDA tool (Questa) reports an error from this code. Rather than doing the import, make the resolution explicit (since there are only two instances) Signed-off-by: Rupert Swarbrick <[email protected]>
rswarbrick
force-pushed
the
import-into-class
branch
from
9bf8b9e to
3832d48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are detailed notes in the commits, but I think this fixes every example where we do the problem.
As such, this fixes #26001.