-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rv_core_ibex] Move rv_core_ibex to allow specialization affecting the register layout #26083
Open
Razer6
wants to merge
11
commits into
lowRISC:master
Choose a base branch
from
Razer6:ipgen-rv-core-ibex
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razer6
requested review from
rswarbrick,
jon-flatley,
a-will and
vogelpi
and removed request for
a team,
msfschaffner,
cfrantz and
jon-flatley
January 31, 2025 11:57
Razer6
force-pushed
the
ipgen-rv-core-ibex
branch
5 times, most recently
from
January 31, 2025 14:02
2d7f8b1
to
a306063
Compare
… name Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Razer6
force-pushed
the
ipgen-rv-core-ibex
branch
7 times, most recently
from
January 31, 2025 19:08
ad6de20
to
034b7d3
Compare
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Razer6
force-pushed
the
ipgen-rv-core-ibex
branch
from
January 31, 2025 20:11
034b7d3
to
6cac821
Compare
Signed-off-by: Robert Schilling <[email protected]>
Razer6
force-pushed
the
ipgen-rv-core-ibex
branch
from
January 31, 2025 20:19
6cac821
to
fcabd55
Compare
NumRegions is different. Darjeeling uses 32 for ROM patching. The others only 2. Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Razer6
force-pushed
the
ipgen-rv-core-ibex
branch
from
January 31, 2025 20:23
fcabd55
to
3df5475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
rv_core_ibex
to ipgen. The reason for this change is to support specialization that affects the register layout. For example in Darjeeling, we use 32 remapping regions (for ROM patching), whereas Earlgrey and Englishbreakfast only uses 2. This parameter changes the register layout, which creates a conflict between those tops.To solve this problem, we move rv_core_ibex to ipgen. This allows the top to specialize the core for their needs, i.e., Darjeeling uses 32 remapping regions, the others only 2.