DM-21697 Fix SpanSet Creation from large circles #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpdf
requested changes
Feb 6, 2020
| { | ||
| double dr = static_cast<double>(r); | ||
| dr *= dr; | ||
| for (auto dy = std::make_pair<int, double>(-r, -r); dy.first <= r; ++dy.first, ++dy.second) { |
There was a problem hiding this comment.
Some C++ style guides frown on applying the increment/decrement operators to floating-point values. However, I don't think the LSST style guide mentions this.
Still, dy.second += 1.0 might help the reader understand the nature of the parallelism a bit more.
| int dx = static_cast<int>(sqrt(r * r - dy * dy)); | ||
| tempVec.push_back(Span(dy + offset.getY(), -dx + offset.getX(), dx + offset.getX())); | ||
| { | ||
| double dr = static_cast<double>(r); |
There was a problem hiding this comment.
I think a comment is necessary to clarify what problem is being avoided by the parallel increment of the integer and the double. And I might name the variable that holds "r-squared" something like r_sq.
timj
force-pushed
the
tickets/DM-21697
branch
2 times, most recently
from
bd9067d
to
95cf2c2
Compare
Fix an issue where data-types were not large enough to hold values that may be plausibly used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where data-types were not large enough to hold values
that may be plausibly used.