Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40556: Add LATISS color terms and turn on by default in initial calibration. #470

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Aug 30, 2023

No description provided.

Copy link
Contributor

@psferguson psferguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

config.photoCal.match.referenceSelection.magLimit.fluxField = "r_flux"
colors = config.photoCal.match.referenceSelection.colorLimits
colors["g-r"] = ColorLimit(primary="g_flux", secondary="r_flux", minimum=0.4, maximum=2.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the fit is pretty sparse at g-r of 2 should the max be 1.4? (I dont feel strongly about this)

Also, do we need an r-i color limit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's sparse, but the color term is defined there and I don't want to get too thin on the ground or else some rapid processing might have trouble.
As for r-i, I went back and forth on this in my mind; I think that the g-r color range will make sure these are all well-behaved stars, but I guess we might need the other cut to make sure they don't have 🤪 i-band observations. Thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, I am in favor of rapid processing working.

I think it would be best if when calibrating r/i band data we reject stars beyond the range where that color term is defined but I imagine this will not effect latiss calibrations too much.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The challenge is that we don't have the ability to do per-band configs. So it's all or nothing. 😬 I'm going to leave it like this; these aren't the most critical cuts (and there's outlier rejection anyway), and the "real" calibration with fgcmcal will be put into the pipeline very soon.

@erykoff erykoff merged commit 235df5f into main Aug 31, 2023
3 checks passed
@erykoff erykoff deleted the tickets/DM-40556 branch August 31, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants