-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-40556: Add LATISS color terms and turn on by default in initial calibration. #470
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5f5b214
Add colorterms for ATLAS Refcat2 -> LATISS (g/r/i).
erykoff 39902c3
Add filterMap to properly map reference catalog to LATISS filters.
erykoff d0021e8
Add color terms to calibrate config and limit color range.
erykoff d872757
Remove extra space.
erykoff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
from lsst.pipe.tasks.colorterms import Colorterm, ColortermDict | ||
|
||
|
||
config.data = { | ||
"atlas_refcat2*": ColortermDict(data={ | ||
"SDSSg_65mm~empty": Colorterm( | ||
primary="g", | ||
secondary="r", | ||
c0=-0.09034144345111599, | ||
c1=0.1710923238086337, | ||
c2=-0.038260355621929296, | ||
), | ||
"SDSSr_65mm~empty": Colorterm( | ||
primary="r", | ||
secondary="i", | ||
c0=0.0073632488906825045, | ||
c1=-0.026620900037027242, | ||
c2=-0.03203533692013322, | ||
), | ||
"SDSSi_65mm~empty": Colorterm( | ||
primary="i", | ||
secondary="r", | ||
c0=0.016940180565664747, | ||
c1=0.0610018330811135, | ||
c2=-0.0722575356707918, | ||
), | ||
# The following two are blank until we have data to measure them. | ||
"SDSSz_65mm~empty": Colorterm( | ||
primary="z", | ||
secondary="z", | ||
), | ||
"SDSSy_65mm~empty": Colorterm( | ||
primary="y", | ||
secondary="y", | ||
), | ||
}), | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
# Mapping of camera filter name: reference catalog filter name | ||
# This file is appropriate for ATLAS Refcat2. | ||
|
||
for source, target in [ | ||
("SDSSg_65mm~empty", "g"), | ||
("SDSSr_65mm~empty", "r"), | ||
("SDSSi_65mm~empty", "i"), | ||
("SDSSz_65mm~empty", "z"), | ||
# ATLAS Refcat2 does not have y band. | ||
("SDSSy_65mm~empty", "z"), | ||
]: | ||
config.filterMap[source] = target |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the fit is pretty sparse at g-r of 2 should the max be 1.4? (I dont feel strongly about this)
Also, do we need an r-i color limit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's sparse, but the color term is defined there and I don't want to get too thin on the ground or else some rapid processing might have trouble.
As for r-i, I went back and forth on this in my mind; I think that the g-r color range will make sure these are all well-behaved stars, but I guess we might need the other cut to make sure they don't have 🤪 i-band observations. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, I am in favor of rapid processing working.
I think it would be best if when calibrating r/i band data we reject stars beyond the range where that color term is defined but I imagine this will not effect latiss calibrations too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The challenge is that we don't have the ability to do per-band configs. So it's all or nothing. 😬 I'm going to leave it like this; these aren't the most critical cuts (and there's outlier rejection anyway), and the "real" calibration with fgcmcal will be put into the pipeline very soon.