DM-41838: Update maxScaledSizeScatter thresholds for LSSTCam-imSim #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the maxScaledSizeScatter to reflect the new metric definition (which results in higher values for this metric). See DM-40668 for details.
parejkoj
reviewed
Nov 27, 2023
| config.select.maxEllipResidual = 0.005 | ||
| config.select.maxScaledSizeScatter = 0.008 | ||
| config.select.maxScaledSizeScatter = 0.011 |
There was a problem hiding this comment.
Is this specific to imSim? It seems like something that should be set either in the package defaults (if it's for all cases of makeWarp) or in the DRP ingredients, so it applies to all instruments.
There was a problem hiding this comment.
These config values depend on typical performance of a given instrument in typical conditions. The appropriate value for HSC is not the same for DC2 is not the same for LATISS.
erykoff
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.