Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-41838: Update maxScaledSizeScatter thresholds for LSSTCam-imSim #489

Merged
merged 1 commit into from
Nov 27, 2023
Merged

DM-41838: Update maxScaledSizeScatter thresholds for LSSTCam-imSim #489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion config/imsim/makeWarp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,9 @@
# After switching to Piff for PSF estimation, these proved too tight for at
# least ci_imsim. The updates just added a bit of padding top of what was
# needed to get all images in ci_imsim through.
#
# The maxScaledSizeScatter has been increased further to reflect the new
# metric definition (which results in higher values for this metric). See
# DM-40668 & DM-41838 for details.
config.select.maxEllipResidual = 0.005
config.select.maxScaledSizeScatter = 0.008
config.select.maxScaledSizeScatter = 0.011
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this specific to imSim? It seems like something that should be set either in the package defaults (if it's for all cases of makeWarp) or in the DRP ingredients, so it applies to all instruments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These config values depend on typical performance of a given instrument in typical conditions. The appropriate value for HSC is not the same for DC2 is not the same for LATISS.