DM-47305: Loosen thresholds for inclusion in coadds for LSSTComCam commissioning #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
force-pushed
the
tickets/DM-47305
branch
2 times, most recently
from
a5c15d1
to
fe74d5b
Compare
mrawls
approved these changes
Oct 31, 2024
| @@ -10,3 +10,6 @@ | |||
|
|
|||
| # Loosened for early ComCam with large PSFs. | |||
| config.photoCal.match.sourceSelection.doUnresolved = False | |||
|
|
|||
| # Exposure summary stats. | |||
| config.computeSummaryStats.load(os.path.join(obsConfigDir, "computeExposureSummaryStats.py")) | |||
There was a problem hiding this comment.
I was about to ask you to also add this to calibrateImage.py but it is already in there, hooray!
config/comCam/makeWarp.py
Outdated
| # Currently allowing BestSeeingSelectVisits.maxPsfFwhm = 2.7 into coadds, so | ||
| # increase the default PSF fwhm (pixels) size. | ||
|
|
||
| # TODO: Change this if/when we tighten the maxPsfFwhm threshold. |
There was a problem hiding this comment.
Please make a ticket for any TODOs, even if it maybe never ends up happening
During initial commissioning, we want a good number of the visits successfully processed through single frame to be eligible for inclusion in the coadds. Thus we need to loosen the image quality metric thresholds for now.
Each task that calls the computeExposureSummaryStats task needs the camera-specific fiducial value overrides.
laurenam
force-pushed
the
tickets/DM-47305
branch
from
fe74d5b
to
4d0b4e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.