Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-47305: Loosen thresholds for inclusion in coadds for LSSTComCam commissioning #574

Merged
merged 2 commits into from
Oct 31, 2024
Merged

DM-47305: Loosen thresholds for inclusion in coadds for LSSTComCam commissioning #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfa58fb
Loosen LSSTComCam image quality limits for coadds
laurenam Oct 30, 2024
4d0b4e2
Add LSSTComCam config for effective metrics
laurenam Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions config/comCam/calibrate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,6 @@

# Loosened for early ComCam with large PSFs.
config.photoCal.match.sourceSelection.doUnresolved = False

# Exposure summary stats.
config.computeSummaryStats.load(os.path.join(obsConfigDir, "computeExposureSummaryStats.py"))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to ask you to also add this to calibrateImage.py but it is already in there, hooray!

41 changes: 41 additions & 0 deletions config/comCam/makeWarp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# This file is part of obs_lsst.
#
# Developed for the LSST Data Management System.
# This product includes software developed by the LSST Project
# (http://www.lsst.org).
# See the COPYRIGHT file at the top-level directory of this distribution
# for details of code ownership.
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the LSST License Statement and
# the GNU General Public License along with this program. If not,
# see <http://www.lsstcorp.org/LegalNotices/>.

"""LSSTComCam-specific overrides for MakeWarpTask"""

# These thresholds are being set quite loosely for early LSSTComCam
# commissioning to make sure we get most of the processed visits
# included in the coadds. These have been chosen based on the data
# in the LSSTComCam/nightlyValidation collection in the embargo_new
# repo on Oct 30, 2024.
config.select.maxEllipResidual = 0.19
config.select.maxScaledSizeScatter = 0.07
config.select.maxPsfTraceRadiusDelta = 1.2
config.select.maxPsfApFluxDelta = 0.19
config.select.maxPsfApCorrSigmaScaledDelta = 0.15

# PSF-matching configs are in units of pix and specific to skymap pixel scale.

# Currently allowing BestSeeingSelectVisits.maxPsfFwhm = 2.7 into coadds, so
# increase the default PSF fwhm (pixels) size.
# TODO DM-47171: optimize this config setting for artifact rejection.
config.modelPsf.defaultFwhm = 11.0
Loading